Sign upLogin

openjaf/cenit

View on GitHub
Star
app/models/setup/base_pull.rb

Summary

Maintainability
F
6 days
Test Coverage

Method pull_request has a Cognitive Complexity of 108 (exceeds 5 allowed). Consider refactoring.
Open

      def pull_request(shared_collection, options = {})
        pull_parameters = options[:pull_parameters] || {}
        missing_parameters = []
        unless options[:ignore_missing_parameters]
          shared_collection.each_pull_parameter do |pull_parameter|
Severity: Minor
Found in app/models/setup/base_pull.rb - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method pull has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

      def pull(shared_collection, pull_request = {})
        pull_request = pull_request.with_indifferent_access
        pull_request = pull_request(shared_collection, pull_request) if pull_request[:pull_data].nil?
        errors = []
        if pull_request[:missing_parameters].blank?
Severity: Minor
Found in app/models/setup/base_pull.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_embedded_items has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

      def check_embedded_items(item, record)
        (item_model = record.class).model_properties_schemas.each do |property, schema|
          next if schema['referenced']
          next unless (property_value = item[property]) && (property_model = item_model.property_model(property))
          next unless (property_data_type = property_model.data_type).get_referenced_by.present?
Severity: Minor
Found in app/models/setup/base_pull.rb - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method pull_request has 135 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def pull_request(shared_collection, options = {})
        pull_parameters = options[:pull_parameters] || {}
        missing_parameters = []
        unless options[:ignore_missing_parameters]
          shared_collection.each_pull_parameter do |pull_parameter|
Severity: Major
Found in app/models/setup/base_pull.rb - About 5 hrs to fix

    File base_pull.rb has 317 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Setup
  class BasePull < Setup::Task
    include UploaderHelper

    abstract_class
    Severity: Minor
    Found in app/models/setup/base_pull.rb - About 3 hrs to fix

      Method pull has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def pull(shared_collection, pull_request = {})
        pull_request = pull_request.with_indifferent_access
        pull_request = pull_request(shared_collection, pull_request) if pull_request[:pull_data].nil?
        errors = []
        if pull_request[:missing_parameters].blank?
      Severity: Major
      Found in app/models/setup/base_pull.rb - About 2 hrs to fix

        Method run has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            def run(message)
      clear_hashes
      if pull_request_hash.present?
        pull_request_hash[:install] = message[:install].to_b if ask_for_install?
        if (pull_parameters = message[:pull_parameters]).is_a?(Hash)
        Severity: Minor
        Found in app/models/setup/base_pull.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def run(message)
      clear_hashes
      if pull_request_hash.present?
        pull_request_hash[:install] = message[:install].to_b if ask_for_install?
        if (pull_parameters = message[:pull_parameters]).is_a?(Hash)
        Severity: Minor
        Found in app/models/setup/base_pull.rb - About 1 hr to fix

          Method check_embedded_items has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def check_embedded_items(item, record)
        (item_model = record.class).model_properties_schemas.each do |property, schema|
          next if schema['referenced']
          next unless (property_value = item[property]) && (property_model = item_model.property_model(property))
          next unless (property_data_type = property_model.data_type).get_referenced_by.present?
          Severity: Minor
          Found in app/models/setup/base_pull.rb - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                              if (obj = (obj.reload rescue nil))
            Severity: Major
            Found in app/models/setup/base_pull.rb - About 45 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      unless collection && fields.all? { |field| Cenit::Utility.eql_content?(collection.send(field), shared_collection.send(field)) }
          fields.each do |field|
            shared_value = shared_collection[field]
            unless collection && Cenit::Utility.eql_content?(collection[field], shared_value)
              collection_data[field] = shared_value
              Severity: Minor
              Found in app/models/setup/base_pull.rb and 1 other location - About 50 mins to fix
              app/models/setup/base_pull.rb on lines 113..121

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 43.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      unless collection && fields.all? { |field| Cenit::Utility.eql_content?(collection.send(field), pull_data[field]) }
          fields.each do |field|
            shared_value = pull_data[field]
            unless collection && Cenit::Utility.eql_content?(collection[field], shared_value)
              collection_data[field] = shared_value
              Severity: Minor
              Found in app/models/setup/base_pull.rb and 1 other location - About 50 mins to fix
              app/models/setup/base_pull.rb on lines 103..111

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 43.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status