Sign upLogin

openjaf/cenit

View on GitHub
Star
lib/mongoff/grid_fs/file_formatter.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method native_hash_format has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

      def native_hash_format(options = {}, alg_delegator_method)
        if (alg_methods = orm_model.data_type.records_methods.select { |alg| %w(to_hash to_json).include?(alg.name) }).present?
          alg_delegator_method =
            if alg_methods.length == 1 || alg_methods[0].name == alg_delegator_method.to_s
              alg_methods[0].name
Severity: Minor
Found in lib/mongoff/grid_fs/file_formatter.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method native_hash_format has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def native_hash_format(options = {}, alg_delegator_method)
        if (alg_methods = orm_model.data_type.records_methods.select { |alg| %w(to_hash to_json).include?(alg.name) }).present?
          alg_delegator_method =
            if alg_methods.length == 1 || alg_methods[0].name == alg_delegator_method.to_s
              alg_methods[0].name
Severity: Minor
Found in lib/mongoff/grid_fs/file_formatter.rb - About 1 hr to fix

    Method to_edi has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def to_edi(options = {})
        if orm_model.data_type.records_methods.any? { |alg| alg.name == 'to_edi' }
          return method_missing(:to_edi, options)
        end
        data = file.data
    Severity: Minor
    Found in lib/mongoff/grid_fs/file_formatter.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status