Sign upLogin

openjaf/cenit

View on GitHub
Star
lib/mongoff/model.rb

Summary

Maintainability
F
5 days
Test Coverage

Class Model has 61 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Model
    include Setup::InstanceModelParser
    include MetadataAccess
    include PrettyErrors
    include ThreadAware
Severity: Major
Found in lib/mongoff/model.rb - About 1 day to fix

    File model.rb has 514 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module Mongoff
  class Model
    include Setup::InstanceModelParser
    include MetadataAccess
    include PrettyErrors
    Severity: Major
    Found in lib/mongoff/model.rb - About 1 day to fix

      Consider simplifying this complex logical expression.
      Open

            if schema.is_a?(Hash) && (schema = schema.reject { |key, _| %w(types contextual_params data filter group xml unique title description edi format example enum readOnly default visible referenced_by maxProperties minProperties auto export_embedded exclusive).include?(key) })
        property_dt = nil
        ns = data_type.namespace
        if (ref = schema['$ref']).is_a?(Array)
          ref = nil
      Severity: Critical
      Found in lib/mongoff/model.rb - About 4 hrs to fix

        Method mongo_value has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            def mongo_value(value, field, schema = nil, &success_block)
      field = '_id' if field.to_s == 'id'
      types =
        if !caching? || schema
          mongo_type_for(field, schema)
        Severity: Minor
        Found in lib/mongoff/model.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method property_model has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
        Open

            def property_model(property)
      property = property.to_s
      model = nil
      if schema.is_a?(Hash) && schema['type'] == 'object' && schema['properties'].is_a?(Hash) && (property_schema = schema['properties'][property])
        if properties_models.key?(property)
        Severity: Minor
        Found in lib/mongoff/model.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method associations has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            def associations
      unless @associations
        @associations = {}.with_indifferent_access
        properties_schemas.each do |property, property_schema|
          if model.model_schema?(property_schema)
        Severity: Minor
        Found in lib/mongoff/model.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method for has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

              def for(options)
        model_name = options[:name]
        cache_model = (cache_models = current_thread_cache)[model_name]
        unless (data_type = (options[:data_type] || (cache_model && cache_model.data_type)))
          raise Exception.new('name or data type required') unless model_name
        Severity: Minor
        Found in lib/mongoff/model.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method check_referenced_schema has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
        Open

            def check_referenced_schema(schema, check_for_array = true)
      if schema.is_a?(Hash) && (schema = schema.reject { |key, _| %w(types contextual_params data filter group xml unique title description edi format example enum readOnly default visible referenced_by maxProperties minProperties auto export_embedded exclusive).include?(key) })
        property_dt = nil
        ns = data_type.namespace
        if (ref = schema['$ref']).is_a?(Array)
        Severity: Minor
        Found in lib/mongoff/model.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method mongo_value has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def mongo_value(value, field, schema = nil, &success_block)
      field = '_id' if field.to_s == 'id'
      types =
        if !caching? || schema
          mongo_type_for(field, schema)
        Severity: Minor
        Found in lib/mongoff/model.rb - About 1 hr to fix

          Method property_model has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def property_model(property)
      property = property.to_s
      model = nil
      if schema.is_a?(Hash) && schema['type'] == 'object' && schema['properties'].is_a?(Hash) && (property_schema = schema['properties'][property])
        if properties_models.key?(property)
          Severity: Minor
          Found in lib/mongoff/model.rb - About 1 hr to fix

            Method method_missing has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                  def method_missing(symbol, *args)
        if !symbol.to_s.end_with?('=') && ((args.length.zero? && block_given?) || args.length == 1 && !block_given?)
          self[symbol] = block_given? ? yield : args[0]
        elsif args.length.zero? && !block_given?
          self[symbol]
            Severity: Minor
            Found in lib/mongoff/model.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method attribute_key has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                def attribute_key(field, field_metadata = {})
      field_metadata[:model] ||= property_model(field)
      model = field_metadata[:model]
      if model&.persistable? && (schema = (field_metadata[:schema] ||= property_schema(field)))['referenced']
        ((schema['type'] == 'array') ? field.to_s.singularize + '_ids' : "#{field}_id").to_sym
            Severity: Minor
            Found in lib/mongoff/model.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method submodel_of? has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                def submodel_of?(model)
      return true if eql?(model) || (@base_model && @base_model.submodel_of?(model))
      base_model =
        if (base_data_type = data_type.find_data_type(data_type.schema['extends']))
          Model.for(data_type: base_data_type, cache: caching?)
            Severity: Minor
            Found in lib/mongoff/model.rb - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                def initialize(data_type, options = {})
      @data_type_id =
        if data_type.is_a?(Setup::BuildInDataType) || options[:cache] || !data_type.persisted?
          data_type
        else
            Severity: Minor
            Found in lib/mongoff/model.rb - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method storage_size has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def storage_size(scale = 1)
      subtype_count = data_type.subtype? && data_type.count
      data_type.all_data_type_storage_collections_names.inject(0) do |size, name|
        s =
          begin
            Severity: Minor
            Found in lib/mongoff/model.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method property_for_attribute has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                def property_for_attribute(name)
      if property?(name)
        name
      else
        match = name.to_s.match(/\A(.+)(_id(s)?)\Z/)
            Severity: Minor
            Found in lib/mongoff/model.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                def storage_size(scale = 1)
      subtype_count = data_type.subtype? && data_type.count
      data_type.all_data_type_storage_collections_names.inject(0) do |size, name|
        s =
          begin
            Severity: Minor
            Found in lib/mongoff/model.rb and 1 other location - About 55 mins to fix
            lib/mongoid/cenit_extension.rb on lines 82..96

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                def property_for_attribute(name)
      if property?(name)
        name
      else
        match = name.to_s.match(/\A(.+)(_id(s)?)\Z/)
            Severity: Minor
            Found in lib/mongoff/model.rb and 1 other location - About 25 mins to fix
            lib/mongoid/cenit_extension.rb on lines 160..169

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 29.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status