openmrs/openmrs-contrib-id

View on GitHub
app/models/user.js

Summary

Maintainability
C
1 day
Test Coverage

File user.js has 375 lines of code (exceeds 250 allowed). Consider refactoring.
Open

'use strict';
/**
 * This file defines the Schema of OpenMRS-ID
 */

Severity: Minor
Found in app/models/user.js - About 5 hrs to fix

    Function findAndSync has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const findAndSync = (filter, callback) => {
    
      const findMongo = cb => {
        User.findOne(filter, (err, user) => {
          if (err) {
    Severity: Major
    Found in app/models/user.js - About 2 hrs to fix

      Function addGroupsAndSave has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      User.prototype.addGroupsAndSave = function(groups, callback) {
        // ToDo May have duplicate problems
        if (!Array.isArray(groups)) {
          groups = [groups];
        }
      Severity: Minor
      Found in app/models/user.js - About 1 hr to fix

        Function findAndSync has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        const findAndSync = (filter, callback) => {
        
          const findMongo = cb => {
            User.findOne(filter, (err, user) => {
              if (err) {
        Severity: Minor
        Found in app/models/user.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status