Sign upLogin

opennorth/citizen_budget_model

View on GitHub
Star
spec/controllers/citizen_budget_model/simulators_controller_spec.rb

Summary

Maintainability
C
1 day
Test Coverage

File simulators_controller_spec.rb has 281 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'rails_helper'

module CitizenBudgetModel
  RSpec.describe SimulatorsController, type: :controller do
    routes { Engine.routes }
Severity: Minor
Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it 'sorts the sections in the simulator' do
          simulator = Simulator.create! valid_attributes_for_admin
          sections = 3.times.map do
            Section.create!(simulator_id: simulator.to_param)
          end
    Severity: Major
    Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb and 1 other location - About 1 hr to fix
    spec/controllers/citizen_budget_model/simulators_controller_spec.rb on lines 309..318

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it 'sorts the sections in the simulator' do
          simulator = Simulator.create! valid_attributes_for_create
          sections = 3.times.map do
            Section.create!(simulator_id: simulator.to_param)
          end
    Severity: Major
    Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb and 1 other location - About 1 hr to fix
    spec/controllers/citizen_budget_model/simulators_controller_spec.rb on lines 129..138

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 52.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

          describe 'GET show' do
        it 'does not assign the unauthorized simulator as @simulator' do
          simulator = Simulator.create! valid_attributes_for_admin
          expect{get(:show, {id: simulator.to_param})}.to raise_error(ActiveRecord::RecordNotFound)
        end
    Severity: Major
    Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb and 2 other locations - About 55 mins to fix
    spec/controllers/citizen_budget_model/simulators_controller_spec.rb on lines 191..200
    spec/controllers/citizen_budget_model/users_controller_spec.rb on lines 131..140

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

          describe 'GET edit' do
        it 'does not assign the unauthorized simulator as @simulator' do
          simulator = Simulator.create! valid_attributes_for_admin
          expect{get(:edit, {id: simulator.to_param})}.to raise_error(ActiveRecord::RecordNotFound)
        end
    Severity: Major
    Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb and 2 other locations - About 55 mins to fix
    spec/controllers/citizen_budget_model/simulators_controller_spec.rb on lines 171..180
    spec/controllers/citizen_budget_model/users_controller_spec.rb on lines 131..140

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 44.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it 'allows any organization_id' do
          simulator = Simulator.create! valid_attributes_for_admin
          put :update, {id: simulator.to_param, simulator: new_attributes_for_admin}
          expect(simulator.reload.name).to eq('Update')
          expect(assigns(:simulator)).to eq(simulator)
    Severity: Minor
    Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb and 1 other location - About 45 mins to fix
    spec/controllers/citizen_budget_model/simulators_controller_spec.rb on lines 244..251

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it 'allows any organization_id' do
          expect {
            post :create, {simulator: valid_attributes_for_admin}
          }.to change(Simulator, :count).by(1)
          expect(assigns(:simulator)).to be_a(Simulator)
    Severity: Minor
    Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb and 1 other location - About 45 mins to fix
    spec/controllers/citizen_budget_model/simulators_controller_spec.rb on lines 206..214

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              it 'does not allow any organization_id' do
            simulator = Simulator.create! valid_attributes_for_create
            put :update, {id: simulator.to_param, simulator: new_attributes_for_admin}
            expect(simulator.reload.name).to eq('Update')
            expect(assigns(:simulator)).to eq(simulator)
    Severity: Minor
    Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb and 1 other location - About 45 mins to fix
    spec/controllers/citizen_budget_model/simulators_controller_spec.rb on lines 97..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              it 'does not allow any organization_id' do
            expect {
              post :create, {simulator: valid_attributes_for_admin}
            }.to change(Simulator, :count).by(1)
            expect(assigns(:simulator)).to be_a(Simulator)
    Severity: Minor
    Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb and 1 other location - About 45 mins to fix
    spec/controllers/citizen_budget_model/simulators_controller_spec.rb on lines 84..92

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 41.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              it 'creates a new Simulator' do
            expect {
              post :create, {simulator: valid_attributes}
            }.to change(Simulator, :count).by(1)
            expect(assigns(:simulator)).to be_a(Simulator)
    Severity: Minor
    Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb and 1 other location - About 35 mins to fix
    spec/controllers/citizen_budget_model/organizations_controller_spec.rb on lines 102..108

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              it 'updates the requested simulator' do
            simulator = Simulator.create! valid_attributes_for_create
            put :update, {id: simulator.to_param, simulator: new_attributes}
            expect(simulator.reload.name).to eq('Update')
            expect(assigns(:simulator)).to eq(simulator)
    Severity: Minor
    Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb and 1 other location - About 35 mins to fix
    spec/controllers/citizen_budget_model/organizations_controller_spec.rb on lines 129..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it 'activates the requested simulator' do
          simulator = Simulator.create! valid_attributes_for_create
          post :activate, {id: simulator.to_param}
          expect(simulator.reload.active).to eq(true)
          expect(assigns(:simulator)).to eq(simulator)
    Severity: Minor
    Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb and 1 other location - About 30 mins to fix
    spec/controllers/citizen_budget_model/simulators_controller_spec.rb on lines 119..124

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            it 'activates the requested simulator' do
          simulator = Simulator.create! valid_attributes_for_admin
          post :activate, {id: simulator.to_param}
          expect(simulator.reload.active).to eq(true)
          expect(assigns(:simulator)).to eq(simulator)
    Severity: Minor
    Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb and 1 other location - About 30 mins to fix
    spec/controllers/citizen_budget_model/simulators_controller_spec.rb on lines 294..299

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 32.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            describe 'with invalid params' do
          it 'assigns the simulator as @simulator' do
            simulator = Simulator.create! valid_attributes_for_create
            put :update, {id: simulator.to_param, simulator: invalid_attributes}
            expect(assigns(:simulator)).to eq(simulator)
    Severity: Minor
    Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb and 2 other locations - About 25 mins to fix
    spec/controllers/citizen_budget_model/organizations_controller_spec.rb on lines 138..143
    spec/controllers/citizen_budget_model/users_controller_spec.rb on lines 203..208

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          describe 'DELETE destroy' do
        it 'destroys the requested simulator' do
          simulator = Simulator.create! valid_attributes_for_admin
          expect {
            delete :destroy, {id: simulator.to_param}
    Severity: Minor
    Found in spec/controllers/citizen_budget_model/simulators_controller_spec.rb and 1 other location - About 25 mins to fix
    spec/controllers/citizen_budget_model/organizations_controller_spec.rb on lines 148..154

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 30.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status