Sign upLogin

openrm/hato

View on GitHub
Star

Showing 16 of 16 total issues

Function getClientClass has 71 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function getClientClass(apiClass) {
    /**
     * Internal class.
     */
    class Client extends apiClass {
Severity: Major
Found in lib/index.js - About 2 hrs to fix

    Function create has 45 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        create() {
        const modes = [Modes.PUBLICATION, Modes.SUBSCRIPTION];
        const open = modes
            .map((mode) => this._chs[mode] = this._create(mode));
        return Promise.all(open)
    Severity: Minor
    Found in plugins/duplex.js - About 1 hr to fix

      Function exchange has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          exchange(name, type, options) {
        assert(name || type,
            'ContextChannel.exchange() requires either `name` or `type`');

        assert(!type || exchangeTypes.includes(type),
      Severity: Minor
      Found in lib/api.js - About 1 hr to fix

        Function connect has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const connect = function(url, socketOptions) {
    const logger = this.logger;
    logger.debug('[AMQP] Connecting to server...');
    return promisify(amqp.connect.bind(amqp, url, socketOptions))
        .then((conn) => {
        Severity: Minor
        Found in lib/client.js - About 1 hr to fix

          Function consume has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              consume(binding, fn, options) {
        // allow to omit the binding key for use with fanout exchanges
        if (arguments.length === 1) return this.consume('', fn);

        assert(typeof binding === 'string' || binding &&
          Severity: Minor
          Found in lib/api.js - About 1 hr to fix

            Function patchChannel has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const patchChannel = function(logger, conn, create) {
    return function() {
        logger.debug('[AMQP] Opening a channel...');
        return promisify(create.bind(conn))
            .then((ch) => {
            Severity: Minor
            Found in lib/client.js - About 1 hr to fix

              Consider simplifying this complex logical expression.
              Open

                  if (err instanceof TypeError ||
        err instanceof ReferenceError ||
        err instanceof SyntaxError ||
        err instanceof RangeError ||
        err instanceof RetryError ||
              Severity: Critical
              Found in plugins/retry/errors.js - About 1 hr to fix

                Function retryOnError has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function retryOnError(fn, retries, computeDelay) {
    return (msg) => {
        const count = context.count(msg.properties.headers);

        if ('x-retry-limit' in msg.properties.headers) {
                Severity: Minor
                Found in plugins/retry/index.js - About 1 hr to fix

                  Function retry has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      retry(retries, backoff) {
        return (connect) => {
            const retryable = (c, ...args) => {
                if (0 < c) this.logger.debug(
                    '[AMQP:conn-retry] Retrying to connect...');
                  Severity: Minor
                  Found in plugins/conn-retry.js - About 1 hr to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        init() {
        this.scopes[CHANNEL] = this.handleBounced();
        this.scopes[PUBLICATION] = this.mandate();
    }
                    Severity: Minor
                    Found in plugins/confirm.js and 1 other location - About 50 mins to fix
                    plugins/encoding.js on lines 11..14

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 52.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        init() {
        this.scopes[SUBSCRIPTION] = this.decode();
        this.scopes[PUBLICATION] = this.encode();
    }
                    Severity: Minor
                    Found in plugins/encoding.js and 1 other location - About 50 mins to fix
                    plugins/confirm.js on lines 17..20

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 52.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    module.exports.UnroutableMessageError = class UnroutableMessageError extends BounceError {
    constructor(msg) {
        super('Message unroutable.', msg);
        this.name = 'UnroutableMessageError';
    }
                    Severity: Minor
                    Found in lib/errors.js and 1 other location - About 45 mins to fix
                    lib/errors.js on lines 82..87

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 50.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                    module.exports.UndeliverableMessageError = class UndeliverableMessageError extends BounceError {
    constructor(msg) {
        super('Message undeliverable immediately.', msg);
        this.name = 'UndeliverableMessageError';
    }
                    Severity: Minor
                    Found in lib/errors.js and 1 other location - About 45 mins to fix
                    lib/errors.js on lines 89..94

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 50.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function reply has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    function reply(ch, msg, err, res, options) {
                    Severity: Minor
                    Found in plugins/rpc/api.js - About 35 mins to fix

                      Function consume has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          consume(binding, fn, options) {
        // allow to omit the binding key for use with fanout exchanges
        if (arguments.length === 1) return this.consume('', fn);

        assert(typeof binding === 'string' || binding &&
                      Severity: Minor
                      Found in lib/api.js - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Function exchange has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                      Open

                          exchange(name, type, options) {
        assert(name || type,
            'ContextChannel.exchange() requires either `name` or `type`');

        assert(!type || exchangeTypes.includes(type),
                      Severity: Minor
                      Found in lib/api.js - About 25 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language