opensheetmusicdisplay/opensheetmusicdisplay

View on GitHub
src/MusicalScore/Graphical/SystemLinesEnum.ts

Summary

Maintainability
B
5 hrs
Test Coverage

Function xmlBarlineStyleToSystemLinesEnum has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    public static xmlBarlineStyleToSystemLinesEnum(xmlValue: string): SystemLinesEnum {
        if (xmlValue === "regular") {
            return SystemLinesEnum.SingleThin;
        } else if (xmlValue === "dotted") {
            return SystemLinesEnum.Dotted;
Severity: Minor
Found in src/MusicalScore/Graphical/SystemLinesEnum.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return SystemLinesEnum.BoldThin;
Severity: Major
Found in src/MusicalScore/Graphical/SystemLinesEnum.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return SystemLinesEnum.Tick;
    Severity: Major
    Found in src/MusicalScore/Graphical/SystemLinesEnum.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return SystemLinesEnum.DoubleThin;
      Severity: Major
      Found in src/MusicalScore/Graphical/SystemLinesEnum.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return SystemLinesEnum.DoubleBold;
        Severity: Major
        Found in src/MusicalScore/Graphical/SystemLinesEnum.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return SystemLinesEnum.None;
          Severity: Major
          Found in src/MusicalScore/Graphical/SystemLinesEnum.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return SystemLinesEnum.ThinBold;
            Severity: Major
            Found in src/MusicalScore/Graphical/SystemLinesEnum.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return SystemLinesEnum.Short;
              Severity: Major
              Found in src/MusicalScore/Graphical/SystemLinesEnum.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return SystemLinesEnum.SingleThin;
                Severity: Major
                Found in src/MusicalScore/Graphical/SystemLinesEnum.ts - About 30 mins to fix

                  There are no issues that match your filters.

                  Category
                  Status