Sign upLogin

opensheetmusicdisplay/opensheetmusicdisplay

View on GitHub
Star
src/MusicalScore/Graphical/WebGLSkyBottomLineBatchCalculatorBackend.ts

Summary

Maintainability
C
1 day
Test Coverage

Function calculateFromCanvas has 38 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected calculateFromCanvas(
        canvas: HTMLCanvasElement,
        _: VF.CanvasContext,
        measures: VexFlowMeasure[],
        samplingUnit: number,
Severity: Minor
Found in src/MusicalScore/Graphical/WebGLSkyBottomLineBatchCalculatorBackend.ts - About 1 hr to fix

    Function calculateFromCanvas has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        protected calculateFromCanvas(
        canvas: HTMLCanvasElement,
        _: VF.CanvasContext,
        measures: VexFlowMeasure[],
        samplingUnit: number,
    Severity: Minor
    Found in src/MusicalScore/Graphical/WebGLSkyBottomLineBatchCalculatorBackend.ts - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function onInitialize has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected onInitialize(tableConfiguration: ISkyBottomLineBatchCalculatorBackendTableConfiguration): void {
        const { elementWidth, elementHeight, numColumns, numRows } = tableConfiguration;
        const canvas: HTMLCanvasElement = document.createElement("canvas");
        canvas.width = elementWidth * numColumns;
        canvas.height = numRows;
    Severity: Minor
    Found in src/MusicalScore/Graphical/WebGLSkyBottomLineBatchCalculatorBackend.ts - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  for (let x: number = 0; x < measureWidth; ++x) {
                skyLine[x] = skyLine[x] === 0 ? lowestSkyLine : skyLine[x];
                bottomLine[x] = bottomLine[x] === elementHeight ? highestBottomLine : bottomLine[x];
            }
      Severity: Major
      Found in src/MusicalScore/Graphical/WebGLSkyBottomLineBatchCalculatorBackend.ts and 1 other location - About 2 hrs to fix
      src/MusicalScore/Graphical/PlainSkyBottomLineBatchCalculatorBackend.ts on lines 91..94

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 85.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (!gl.getShaderParameter(shader, gl.COMPILE_STATUS)) {
        log.warn("Shader compilation failed\n" + gl.getShaderInfoLog(shader));
        gl.deleteShader(shader);
        throw new Error("WebGL shader compilation failed");
    }
      Severity: Major
      Found in src/MusicalScore/Graphical/WebGLSkyBottomLineBatchCalculatorBackend.ts and 1 other location - About 1 hr to fix
      src/MusicalScore/Graphical/WebGLSkyBottomLineBatchCalculatorBackend.ts on lines 46..50

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if (!gl.getProgramParameter(program, gl.LINK_STATUS)) {
        log.warn("WebGLSkyBottomLineCalculatorBackend: WebGL program link failed\n" + gl.getProgramInfoLog(program));
        gl.deleteProgram(program);
        throw new Error("WebGL program link failed");
    }
      Severity: Major
      Found in src/MusicalScore/Graphical/WebGLSkyBottomLineBatchCalculatorBackend.ts and 1 other location - About 1 hr to fix
      src/MusicalScore/Graphical/WebGLSkyBottomLineBatchCalculatorBackend.ts on lines 27..31

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status