openva/rs-machine

File cleanup.php has 685 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

###
# MISC. DATA CLEAN UP FUNCTIONS
#

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                if ($this_vote['R']['Y'] == $this_vote['R']['N']) {
                    $this_vote['R']['rating'] = 0;
                } elseif (($this_vote['R']['Y'] == 0) || ($this_vote['R']['N'] == 0)) {
                    $this_vote['R']['rating'] = 1;
                } elseif ($this_vote['R']['Y'] < $this_vote['R']['N']) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

                if ($this_vote['D']['Y'] == $this_vote['D']['N']) {
                    $this_vote['D']['rating'] = 0;
                } elseif (($this_vote['D']['Y'] == 0) || ($this_vote['D']['N'] == 0)) {
                    $this_vote['D']['rating'] = 1;
                } elseif ($this_vote['D']['Y'] < $this_vote['D']['N']) {

• Read up
  Read up

File resolve_chyrons.php has 420 lines of code (exceeds 250 allowed). Consider refactoring.

Open

 <?php

// Store the prior match and try it as the first option on the next time around. No need to
// start from zero when we know there's a pretty good chance that each name is going to
// occur repeatedly.

File meetings.php has 282 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

###
# Retrieve and Store the Meeting Schedule
#

Identical blocks of code found in 3 locations. Consider refactoring.

Open

    if ($total > 0) {
        arsort($tmp);

        # Populate an array that we use to determine overall partisanship. 0 = Democratic and 100 =
        # Republican. Because our number is based on the majority support, we need to rescale it.

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

    if ($total > 0) {
        arsort($tmp);

        # Populate an array that we use to determine overall partisanship. 0 = Democratic and 100 =
        # Republican. Because our number is based on the majority support, we need to rescale it.

• Read up
  Read up

Identical blocks of code found in 3 locations. Consider refactoring.

Open

    if ($total > 0) {
        arsort($tmp);

        # Populate an array that we use to determine overall partisanship. 0 = Democratic and 100 =
        # Republican. Because our number is based on the majority support, we need to rescale it.

• Read up
  Read up

File legislators.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

/*
 * Connect to the database
 */

Consider simplifying this complex logical expression.

Open

         if (
             (substr($chyron['raw_text'], 0, 2) == 's8')
             ||
             (substr($chyron['raw_text'], 0, 2) == '58')
             ||

File detect_faces.php has 259 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

error_reporting(E_ALL);
ini_set('display_errors', 1);

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    foreach ($html as $line) {
        if (stristr($line, 'legp504') !== false) {
            ereg('href="/cgi-bin/legp504\.exe\?' . $bill['session_lis_id'] . '\+mbr\+([A-Z]{1}[0-9]*)"', $line, $copatron);
            if (!empty($copatron[1])) {
                # Build up an array of copatrons for this bill.

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    foreach ($html as $line) {
        if (stristr($line, 'legp504') !== false) {
            //ereg('href="/cgi-bin/legp504\.exe\?'.$bill['session_lis_id'].'\+mbr\+([A-Z]{1}[0-9]*)"', $line, $copatron);
            preg_match('/href="\/cgi-bin\/legp504\.exe\?' . $bill['session_lis_id'] . '\+mbr\+([A-Z]{1}[0-9]*)"/', $line, $copatron);

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

if (file_exists($hash_path)) {
    $hashes = file_get_contents($hash_path);
    if ($hashes !== false) {
        $hashes = unserialize($hashes);
    } else {

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

if (file_exists($hash_path)) {
    $hashes = file_get_contents($hash_path);
    if ($hashes !== false) {
        $hashes = unserialize($hashes);
    } else {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

         if (
             (substr($chyron['raw_text'], 0, 2) == 's8')
             ||
             (substr($chyron['raw_text'], 0, 2) == '58')
             ||

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

         } elseif (
             (substr($chyron['raw_text'], 0, 3) == 'hjr')
             ||
             (substr($chyron['raw_text'], 0, 3) == 'pur')
             ||

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

         } elseif (
             (substr($chyron['raw_text'], 0, 2) == 'I ')
             ||
             (substr($chyron['raw_text'], 0, 2) == '| ')
             ||

• Read up
  Read up

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 15 and the first side effect is on line 3.

Open

<?php

• Exclude checks
  • Disable engine
  • Disable check

A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line 21 and the first side effect is on line 1.

Open

 <?php

• Exclude checks
  • Disable engine
  • Disable check