Sign upLogin

opf/openproject

View on GitHub
Star
app/models/work_package/pdf_export/gantt/gantt_builder.rb

Summary

Maintainability
D
3 days
Test Coverage

Class GanttBuilder has 76 methods (exceeds 20 allowed). Consider refactoring.
Open

  class GanttBuilder
    include Redmine::I18n
    BAR_CELL_PADDING = 5.to_f
    TEXT_CELL_PADDING_H = 3.to_f
    TEXT_CELL_PADDING_V = 1.to_f
Severity: Major
Found in app/models/work_package/pdf_export/gantt/gantt_builder.rb - About 1 day to fix

    File gantt_builder.rb has 529 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module WorkPackage::PDFExport::Gantt
  class GanttBuilder
    include Redmine::I18n
    BAR_CELL_PADDING = 5.to_f
    TEXT_CELL_PADDING_H = 3.to_f
    Severity: Major
    Found in app/models/work_package/pdf_export/gantt/gantt_builder.rb - About 1 day to fix

      Method build_dep_lines has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

          def build_dep_lines(page_groups)
      @all_work_packages.each do |work_package|
        work_package.relations.each do |relation|
          target_work_package = relation.other_work_package(work_package)
          next unless @all_work_packages.include?(target_work_package)
      Severity: Minor
      Found in app/models/work_package/pdf_export/gantt/gantt_builder.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method build_header_cells_parts has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          def build_header_cells_parts(columns, top, height, mapping_lambda, compare_lambda, title_lambda)
      Severity: Minor
      Found in app/models/work_package/pdf_export/gantt/gantt_builder.rb - About 45 mins to fix

        Method build_multi_group_dep_line_backward has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            def build_multi_group_dep_line_backward(source, target,
                                            start_page_index, finish_page_index, page_groups)
        Severity: Minor
        Found in app/models/work_package/pdf_export/gantt/gantt_builder.rb - About 35 mins to fix

          Method build_multi_group_dep_line_forward has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def build_multi_group_dep_line_forward(source, target,
                                           start_page_index, finish_page_index, page_groups)
          Severity: Minor
          Found in app/models/work_package/pdf_export/gantt/gantt_builder.rb - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def build_header_cells_quarters(top, height, columns)
      build_header_cells_parts(columns, top, height,
                               ->(date) { [date.year, date.quarter] },
                               ->(date, quarter_tuple) {
                                 date.year == quarter_tuple[0] && date.quarter == quarter_tuple[1]
            Severity: Minor
            Found in app/models/work_package/pdf_export/gantt/gantt_builder.rb and 1 other location - About 40 mins to fix
            app/models/work_package/pdf_export/gantt/gantt_builder.rb on lines 323..327

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 38.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                def build_header_cells_weeks(top, height, columns)
      build_header_cells_parts(columns, top, height,
                               ->(date) { [date.year, date.cweek] },
                               ->(date, week_tuple) { date.year == week_tuple[0] && date.cweek == week_tuple[1] },
                               ->(week_tuple) { "W#{week_tuple[1]}" })
            Severity: Minor
            Found in app/models/work_package/pdf_export/gantt/gantt_builder.rb and 1 other location - About 40 mins to fix
            app/models/work_package/pdf_export/gantt/gantt_builder.rb on lines 302..308

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 38.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status