Sign upLogin

opf/openproject

View on GitHub
Star
frontend/src/app/shared/components/grids/widgets/custom-text/custom-text-edit-field.service.ts

Summary

Maintainability
B
5 hrs
Test Coverage

CustomTextEditFieldService has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

@Injectable()
export class CustomTextEditFieldService extends EditFieldHandler {
  public fieldName = 'text';

  public valueChanged$:BehaviorSubject<string>;
Severity: Minor
Found in frontend/src/app/shared/components/grids/widgets/custom-text/custom-text-edit-field.service.ts - About 2 hrs to fix

    Function initializeChangeset has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private initializeChangeset(value:GridWidgetResource) {
    const schemaHref = 'customtext-schema';
    const grid:GridResource = value.grid;
    const resourceSource:HalSource = {
      text: value.options.text,
    Severity: Minor
    Found in frontend/src/app/shared/components/grids/widgets/custom-text/custom-text-edit-field.service.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        public get schema():IFieldSchema {
    return {
      name: I18n.t('js.grid.widgets.custom_text.title'),
      writable: true,
      required: false,
      Severity: Minor
      Found in frontend/src/app/shared/components/grids/widgets/custom-text/custom-text-edit-field.service.ts and 1 other location - About 50 mins to fix
      frontend/src/app/features/work-packages/components/work-package-comment/work-package-comment-field-handler.ts on lines 51..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

        constructor(protected elementRef:ElementRef,
    protected injector:Injector,
    protected halResource:HalResourceService,
    protected schemaCache:SchemaCacheService) {
    super();
      Severity: Major
      Found in frontend/src/app/shared/components/grids/widgets/custom-text/custom-text-edit-field.service.ts and 7 other locations - About 45 mins to fix
      frontend/src/app/core/main-menu/main-menu-toggle.component.ts on lines 54..61
      frontend/src/app/features/work-packages/components/wp-buttons/wp-status-button/wp-status-button.component.ts on lines 56..61
      frontend/src/app/features/work-packages/components/wp-relations/wp-relations-hierarchy/wp-relations-hierarchy.directive.ts on lines 65..70
      frontend/src/app/features/work-packages/components/wp-relations/wp-relations.component.ts on lines 68..73
      frontend/src/app/features/work-packages/components/wp-watcher-button/wp-watcher-button.component.ts on lines 60..65
      frontend/src/app/shared/components/autocompleter/draggable-autocomplete/draggable-autocomplete.component.ts on lines 83..90
      frontend/src/app/shared/components/resizer/resizer/wp-resizer.component.ts on lines 78..83

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status