Sign upLogin

opf/openproject

View on GitHub
Star
frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts

Summary

Maintainability
C
1 day
Test Coverage

FiltersFormController has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

export default class FiltersFormController extends Controller {
  static paramsToCopy = ['sortBy', 'columns', 'query_id', 'per_page'];

  static targets = [
    'filterFormToggle',
Severity: Minor
Found in frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts - About 2 hrs to fix

    Function parseFilterValue has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

      private parseFilterValue(filterName:string, filterType:string, operator:string) {
    const valueContainer = this.filterValueContainerTargets.find((filterValueContainer) => filterValueContainer.getAttribute('data-filter-name') === filterName);

    if (valueContainer) {
      const checkbox = valueContainer.querySelector('input[type="checkbox"]') as HTMLInputElement;
    Severity: Minor
    Found in frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File filters-form.controller.ts has 251 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * -- copyright
 * OpenProject is an open source project management software.
 * Copyright (C) 2023 the OpenProject GmbH
 *
    Severity: Minor
    Found in frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts - About 2 hrs to fix

      Function setValueVisibility has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        setValueVisibility({ target, params: { filterName } }:{ target:HTMLSelectElement, params:{ filterName:string } }) {
    const selectedOperator = target.value;
    const valueContainer = this.filterValueContainerTargets.find((filterValueContainer) => filterValueContainer.getAttribute('data-filter-name') === filterName);
    if (valueContainer) {
      if (this.noValueOperators.includes(selectedOperator)) {
      Severity: Minor
      Found in frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

              return this.parseDateFilterValue(valueContainer, filterName);
      Severity: Major
      Found in frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return [value];
        Severity: Major
        Found in frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return null;
          Severity: Major
          Found in frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts - About 30 mins to fix

            Function toggleMultiSelect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              toggleMultiSelect({ params: { filterName } }:{ params:{ filterName:string } }) {
    const valueContainer = this.filterValueContainerTargets.find((filterValueContainer) => filterValueContainer.getAttribute('data-filter-name') === filterName);
    const singleSelect = this.filterValueSelectTargets.find((selectField) => !selectField.multiple && selectField.getAttribute('data-filter-name') === filterName);
    const multiSelect = this.filterValueSelectTargets.find((selectField) => selectField.multiple && selectField.getAttribute('data-filter-name') === filterName);
    if (valueContainer && singleSelect && multiSelect) {
            Severity: Minor
            Found in frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  } else if (selectedOperator === this.onDateOperator) {
        valueContainer.classList.add('on-date');
        valueContainer.classList.remove('days');
        valueContainer.classList.remove('between-dates');
      } else if (selectedOperator === this.betweenDatesOperator) {
            Severity: Major
            Found in frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts and 2 other locations - About 40 mins to fix
            frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts on lines 185..197
            frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts on lines 193..197

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  } else if (selectedOperator === this.betweenDatesOperator) {
        valueContainer.classList.add('between-dates');
        valueContainer.classList.remove('days');
        valueContainer.classList.remove('on-date');
      }
            Severity: Major
            Found in frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts and 2 other locations - About 40 mins to fix
            frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts on lines 185..197
            frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts on lines 189..197

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  if (this.daysOperators.includes(selectedOperator)) {
        valueContainer.classList.add('days');
        valueContainer.classList.remove('on-date');
        valueContainer.classList.remove('between-dates');
      } else if (selectedOperator === this.onDateOperator) {
            Severity: Major
            Found in frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts and 2 other locations - About 40 mins to fix
            frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts on lines 189..197
            frontend/src/stimulus/controllers/dynamic/filter/filters-form.controller.ts on lines 193..197

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 49.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status