Sign upLogin

opf/openproject

View on GitHub
Star
lib_static/redmine/diff/array_string_diff.rb

Summary

Maintainability
C
1 day
Test Coverage

Method lcs has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def self.lcs(a, b)
    astart = 0
    bstart = 0
    afinish = a.length - 1
    bfinish = b.length - 1
Severity: Minor
Found in lib_static/redmine/diff/array_string_diff.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method lcs has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.lcs(a, b)
    astart = 0
    bstart = 0
    afinish = a.length - 1
    bfinish = b.length - 1
Severity: Minor
Found in lib_static/redmine/diff/array_string_diff.rb - About 1 hr to fix

    Method compactdiffs has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def compactdiffs
    diffs = []
    @diffs.each do |df|
      i = 0
      curdiff = []
    Severity: Minor
    Found in lib_static/redmine/diff/array_string_diff.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method makediff has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def makediff(a, b)
    mvector = self.class.lcs(a, b)
    ai = bi = 0
    while ai < mvector.length
      bline = mvector[ai]
    Severity: Minor
    Found in lib_static/redmine/diff/array_string_diff.rb - About 1 hr to fix

      Method makediff has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def makediff(a, b)
    mvector = self.class.lcs(a, b)
    ai = bi = 0
    while ai < mvector.length
      bline = mvector[ai]
      Severity: Minor
      Found in lib_static/redmine/diff/array_string_diff.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          while astart <= afinish && bstart <= bfinish && a[afinish] == b[bfinish]
      mvector[afinish] = bfinish
      afinish -= 1
      bfinish -= 1
    end
      Severity: Minor
      Found in lib_static/redmine/diff/array_string_diff.rb and 1 other location - About 25 mins to fix
      lib_static/redmine/diff/array_string_diff.rb on lines 47..51

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          while astart <= afinish && bstart <= afinish && a[astart] == b[bstart]
      mvector[astart] = bstart
      astart += 1
      bstart += 1
    end
      Severity: Minor
      Found in lib_static/redmine/diff/array_string_diff.rb and 1 other location - About 25 mins to fix
      lib_static/redmine/diff/array_string_diff.rb on lines 54..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 29.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status