Sign upLogin

opf/openproject

View on GitHub
Star
modules/backlogs/lib/open_project/backlogs/list.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method fix_other_work_package_positions has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    def fix_other_work_package_positions
      if changes.slice("project_id", "type_id", "version_id").present?
        if changes.slice("project_id", "version_id").blank? and
           Story.types.include?(type_id.to_i) and
           Story.types.include?(type_id_was.to_i)
Severity: Minor
Found in modules/backlogs/lib/open_project/backlogs/list.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method fix_other_work_package_positions has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def fix_other_work_package_positions
      if changes.slice("project_id", "type_id", "version_id").present?
        if changes.slice("project_id", "version_id").blank? and
           Story.types.include?(type_id.to_i) and
           Story.types.include?(type_id_was.to_i)
Severity: Minor
Found in modules/backlogs/lib/open_project/backlogs/list.rb - About 1 hr to fix

    Method fix_own_work_package_position has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def fix_own_work_package_position
      if changes.slice("project_id", "type_id", "version_id").present?
        if changes.slice("project_id", "version_id").blank? and
           Story.types.include?(type_id.to_i) and
           Story.types.include?(type_id_was.to_i)
    Severity: Minor
    Found in modules/backlogs/lib/open_project/backlogs/list.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status