Sign upLogin

opf/openproject

View on GitHub
Star
modules/backlogs/lib/open_project/backlogs/patches/versions_controller_patch.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method included has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.included(base)
    base.class_eval do
      include VersionSettingsHelper
      helper :version_settings
Severity: Minor
Found in modules/backlogs/lib/open_project/backlogs/patches/versions_controller_patch.rb - About 1 hr to fix

    Method whitelist_update_params has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def whitelist_update_params
        if @project != @version.project
          # Make sure only the version_settings_attributes
          # (column=left|right|none) can be stored when current project does not
          # equal the version project (which is valid in inherited versions)
    Severity: Minor
    Found in modules/backlogs/lib/open_project/backlogs/patches/versions_controller_patch.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status