Sign upLogin

opf/openproject

View on GitHub
Star
modules/github_integration/frontend/module/pull-request/pull-request.component.ts

Summary

Maintainability
B
6 hrs
Test Coverage

Function checkRunStateIcon has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public checkRunStateIcon(checkRun:IGithubCheckRunResource) {
    switch (this.checkRunState(checkRun)) {
      case 'success': {
        return 'checkmark';
      }
Severity: Minor
Found in modules/github_integration/frontend/module/pull-request/pull-request.component.ts - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

            return 'redo';
    Severity: Major
    Found in modules/github_integration/frontend/module/pull-request/pull-request.component.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return 'not-supported';
      Severity: Major
      Found in modules/github_integration/frontend/module/pull-request/pull-request.component.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return 'minus1';
        Severity: Major
        Found in modules/github_integration/frontend/module/pull-request/pull-request.component.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return 'warning';
          Severity: Major
          Found in modules/github_integration/frontend/module/pull-request/pull-request.component.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return 'minus1';
            Severity: Major
            Found in modules/github_integration/frontend/module/pull-request/pull-request.component.ts - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return 'reminder';
              Severity: Major
              Found in modules/github_integration/frontend/module/pull-request/pull-request.component.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return 'not-supported';
                Severity: Major
                Found in modules/github_integration/frontend/module/pull-request/pull-request.component.ts - About 30 mins to fix

                  Similar blocks of code found in 18 locations. Consider refactoring.
                  Open

                    public text = {
    label_created_by: this.I18n.t('js.label_created_by'),
    label_last_updated_on: this.I18n.t('js.label_last_updated_on'),
    label_details: this.I18n.t('js.label_details'),
    label_actions: this.I18n.t('js.github_integration.github_actions'),
                  Severity: Major
                  Found in modules/github_integration/frontend/module/pull-request/pull-request.component.ts and 17 other locations - About 1 hr to fix
                  frontend/src/app/features/bim/ifc_models/pages/viewer/ifc-viewer-page.component.ts on lines 96..101
                  frontend/src/app/features/projects/components/new-project/new-project.component.ts on lines 40..45
                  frontend/src/app/features/user-preferences/reminder-settings/pause-reminders/pause-reminders.component.ts on lines 30..35
                  frontend/src/app/features/work-packages/components/work-package-comment/work-package-comment.component.ts on lines 71..76
                  frontend/src/app/features/work-packages/components/wp-activity/user/user-activity.component.ts on lines 94..99
                  frontend/src/app/features/work-packages/components/wp-baseline/baseline-legends/baseline-legends.component.ts on lines 81..86
                  frontend/src/app/features/work-packages/components/wp-baseline/baseline-modal/baseline-modal.component.ts on lines 46..52
                  frontend/src/app/features/work-packages/components/wp-breadcrumb/wp-breadcrumb-parent.component.ts on lines 48..53
                  frontend/src/app/features/work-packages/components/wp-buttons/wp-create-button/wp-create-button.component.ts on lines 59..64
                  frontend/src/app/features/work-packages/components/wp-timer-button/wp-timer-button.component.ts on lines 81..86
                  frontend/src/app/shared/components/grids/widgets/time-entries/current-user/configuration-modal/configuration.modal.ts on lines 18..23
                  frontend/src/app/shared/components/modals/export-modal/wp-table-export.modal.ts on lines 39..44
                  frontend/src/app/shared/components/modals/share-modal/query-sharing-form.component.ts on lines 27..33
                  frontend/src/app/shared/components/table-pagination/table-pagination.component.ts on lines 63..68
                  frontend/src/app/shared/components/time_entries/edit/trigger-actions-entry.component.ts on lines 55..60
                  frontend/src/app/shared/components/work-package-graphs/configuration-modal/wp-graph-configuration.modal.ts on lines 42..48
                  modules/gitlab_integration/frontend/module/merge-request/merge-request.component.ts on lines 48..53

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 74.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status