Sign upLogin

ophrescue/RescueRails

View on GitHub
Star
app/controllers/users_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Method user_params has 141 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def user_params
    if current_user && current_user.admin?
      params.require(:user)
        .permit(:name,
                :avatar,
Severity: Major
Found in app/controllers/users_controller.rb - About 5 hrs to fix

    File users_controller.rb has 269 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class UsersController < Clearance::UsersController
  include ApplicationHelper

  before_action :select_bootstrap41
  before_action :require_login
    Severity: Minor
    Found in app/controllers/users_controller.rb - About 2 hrs to fix

      Method init_fields has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        def init_fields
    @user.build_agreement unless @user.agreement
    @user.build_confidentiality_agreement unless @user.confidentiality_agreement
    @user.build_code_of_conduct_agreement unless @user.code_of_conduct_agreement
    @user.build_insurance_training_agreement unless @user.insurance_training_agreement
      Severity: Minor
      Found in app/controllers/users_controller.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status