Sign upLogin

opnmind/php-svg

View on GitHub
Star

Showing 35 of 35 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace Opnmind\SVG\Nodes\Shapes;

use Opnmind\SVG\Nodes\SVGNode;
Severity: Major
Found in src/Nodes/Shapes/SVGLine.php and 2 other locations - About 1 day to fix
src/Nodes/Shapes/SVGEllipse.php on lines 1..127
src/Nodes/Shapes/SVGRect.php on lines 1..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 305.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace Opnmind\SVG\Nodes\Shapes;

use Opnmind\SVG\Nodes\SVGNode;
Severity: Major
Found in src/Nodes/Shapes/SVGEllipse.php and 2 other locations - About 1 day to fix
src/Nodes/Shapes/SVGLine.php on lines 1..127
src/Nodes/Shapes/SVGRect.php on lines 1..123

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 305.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

<?php

namespace Opnmind\SVG\Nodes\Shapes;

use Opnmind\SVG\Nodes\SVGNode;
Severity: Major
Found in src/Nodes/Shapes/SVGRect.php and 2 other locations - About 1 day to fix
src/Nodes/Shapes/SVGEllipse.php on lines 1..127
src/Nodes/Shapes/SVGLine.php on lines 1..127

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 305.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method parseColor has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function parseColor($color)
    {
        $colorLower = strtolower($color);
        if (isset(self::$namedColors[$colorLower])) {
            return self::$namedColors[$colorLower];
Severity: Minor
Found in src/SVG.php - About 1 hr to fix

    Method renderStroke has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function renderStroke($image, array $params, $color, $strokeWidth)
    {
        imagesetthickness($image, $strokeWidth);

        $x1 = $params['x1'];
    Severity: Minor
    Found in src/Rasterization/Renderers/SVGRectRenderer.php - About 1 hr to fix

      Avoid using undefined variables such as '$text1' which will lead to PHP notices.
      Open

              $this->setContent($text1);
      Severity: Minor
      Found in src/Nodes/Shapes/SVGTextBox.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$params' which will lead to PHP notices.
      Open

                  $params['y'],
      Severity: Minor
      Found in src/Rasterization/Renderers/SVGTextRenderer.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$params' which will lead to PHP notices.
      Open

                  $params['font-family'],
      Severity: Minor
      Found in src/Rasterization/Renderers/SVGTextRenderer.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$params' which will lead to PHP notices.
      Open

                  $params['font-size'],
      Severity: Minor
      Found in src/Rasterization/Renderers/SVGTextRenderer.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$params' which will lead to PHP notices.
      Open

                  $params['text']
      Severity: Minor
      Found in src/Rasterization/Renderers/SVGTextRenderer.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$params' which will lead to PHP notices.
      Open

                  $params['x'],
      Severity: Minor
      Found in src/Rasterization/Renderers/SVGTextRenderer.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$y' which will lead to PHP notices.
      Open

              return $this->setAttribute('y', $y);
      Severity: Minor
      Found in src/Nodes/Shapes/SVGText.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$params' which will lead to PHP notices.
      Open

                  $params['fill'],
      Severity: Minor
      Found in src/Rasterization/Renderers/SVGTextRenderer.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Avoid using undefined variables such as '$strokeWidth' which will lead to PHP notices.
      Open

              imagesetthickness($image, $strokeWidth);
      Severity: Minor
      Found in src/Rasterization/Renderers/SVGTextRenderer.php by phpmd

      UndefinedVariable

      Since: 2.8.0

      Detects when a variable is used that has not been defined before.

      Example

      class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

      Source https://phpmd.org/rules/cleancode.html#undefinedvariable

      Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct($x1 = null, $y1 = null, $x2 = null, $y2 = null, $text = null, $fontsize = null, $color = null, $fontfile = null)
      Severity: Major
      Found in src/Nodes/Shapes/SVGTextBox.php - About 1 hr to fix

        Function getSerializableAttributes has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getSerializableAttributes()
    {
        $attrs = parent::getSerializableAttributes();

        if ($this->root) {
        Severity: Minor
        Found in src/Nodes/Structures/SVGDocumentFragment.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct($x = null, $y = null, $text1 = null, $fontsize = null, $color = null, $fontfile = null)
        Severity: Minor
        Found in src/Nodes/Shapes/SVGText.php - About 45 mins to fix

          Method calculateCubic has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private static function calculateCubic($p0, $p1, $p2, $p3, $t)
          Severity: Minor
          Found in src/Rasterization/Path/SVGBezierApproximator.php - About 35 mins to fix

            Method cubic has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function cubic($p0, $p1, $p2, $p3, $accuracy = 1)
            Severity: Minor
            Found in src/Rasterization/Path/SVGBezierApproximator.php - About 35 mins to fix

              Function parseCommandChain has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function parseCommandChain($id, array $args, array &$commands)
    {
        if (!isset(self::$commandLengths[$id])) {
            // unknown command
            return false;
              Severity: Minor
              Found in src/Rasterization/Path/SVGPathParser.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language