Sign upLogin

oppia/oppia

View on GitHub
Star
core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts

Summary

Maintainability
F
2 wks
Test Coverage

File opportunities-list.component.spec.ts has 924 lines of code (exceeds 250 allowed). Consider refactoring.
Open

// Copyright 2021 The Oppia Authors. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the 'License');
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
Severity: Major
Found in core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts - About 2 days to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const explorationOpportunitiesLoad1: ExplorationOpportunity[] = [
      {
        id: 'id1',
        labelText: 'text',
        labelColor: 'red',
    Severity: Major
    Found in core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts and 1 other location - About 4 days to fix
    core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts on lines 607..768

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 688.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const explorationOpportunitiesLoad1: ExplorationOpportunity[] = [
      {
        id: 'id1',
        labelText: 'text',
        labelColor: 'red',
    Severity: Major
    Found in core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts and 1 other location - About 4 days to fix
    core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts on lines 75..236

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 688.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const explorationOpportunitiesLoad2: ExplorationOpportunity[] = [
      {
        id: 'id17',
        labelText: 'text',
        labelColor: 'red',
    Severity: Major
    Found in core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts and 1 other location - About 2 days to fix
    core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts on lines 770..871

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 436.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const explorationOpportunitiesLoad2: ExplorationOpportunity[] = [
      {
        id: 'id17',
        labelText: 'text',
        labelColor: 'red',
    Severity: Major
    Found in core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts and 1 other location - About 2 days to fix
    core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts on lines 238..339

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 436.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it(
      'should subscribe to pinnedOpportunitiesChanged and call' +
        'pinOpportunity',
      () => {
        const updatedData = {
    Severity: Major
    Found in core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts and 1 other location - About 3 hrs to fix
    core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts on lines 984..1001

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 98.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        it(
      'should subscribe to unpinnedOpportunitiesChanged and call' +
        'unpinOpportunity',
      () => {
        const updatedData = {
    Severity: Major
    Found in core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts and 1 other location - About 3 hrs to fix
    core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts on lines 965..982

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 98.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

      beforeEach(() => {
    fixture = TestBed.createComponent(OpportunitiesListComponent);
    component = fixture.componentInstance;
    translationLanguageService = TestBed.inject(TranslationLanguageService);
    translationTopicService = TestBed.inject(TranslationTopicService);
    Severity: Major
    Found in core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts and 8 other locations - About 2 hrs to fix
    core/templates/components/keyboard-shortcut-help/keyboard-shortcut-help-modal.component.spec.ts on lines 56..62
    core/templates/pages/classroom-page/classroom-page-root.component.spec.ts on lines 52..60
    core/templates/pages/collection-editor-page/navbar/collection-editor-navbar-breadcrumb.component.spec.ts on lines 70..80
    core/templates/pages/diagnostic-test-player-page/diagnostic-test-player.component.spec.ts on lines 98..106
    core/templates/pages/email-dashboard-pages/email-dashboard-page.component.spec.ts on lines 64..70
    core/templates/pages/library-page/search-results/activity-tiles-infinity-grid.component.spec.ts on lines 55..61
    core/templates/pages/skill-editor-page/editor-tab/skill-description-editor/skill-description-editor.component.spec.ts on lines 54..61
    core/templates/pages/topic-editor-page/modal-templates/questions-opportunities-select-difficulty-modal.component.spec.ts on lines 249..257

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        TestBed.configureTestingModule({
      imports: [HttpClientTestingModule, MatIconModule],
      declarations: [OpportunitiesListComponent],
      providers: [
        ContributionOpportunitiesService,
    Severity: Minor
    Found in core/templates/pages/contributor-dashboard-page/opportunities-list/opportunities-list.component.spec.ts and 1 other location - About 45 mins to fix
    core/templates/pages/admin-page/roles-tab/admin-roles-tab.component.spec.ts on lines 99..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status