Sign upLogin

opro/opro

View on GitHub
Star
lib/opro/auth_provider/devise.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method find_user_for_auth has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

      def find_user_for_auth(params)
        return false if params[:password].blank?
        find_params = params.each_with_object({}) {|(key,value), hash| hash[key] = value if ::Devise.authentication_keys.include?(key.to_sym) }
        # Try to get fancy, some clients have :username hardcoded, if we have nothing in our find hash
        # we can make an educated guess here
Severity: Minor
Found in lib/opro/auth_provider/devise.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status