Sign upLogin

opstree/druid-exporter

View on GitHub
Star

Showing 13 of 13 total issues

Function DruidHTTPEndpoint has a Cognitive Complexity of 63 (exceeds 20 allowed). Consider refactoring.
Open

func DruidHTTPEndpoint(metricsCleanupTTL int, disableHistogram bool, histogram *prometheus.HistogramVec, gauge *prometheus.GaugeVec, dnsCache *cache.Cache) http.HandlerFunc {
    gaugeCleaner := newCleaner(gauge, metricsCleanupTTL)
    return func(w http.ResponseWriter, req *http.Request) {
        var druidData []map[string]interface{}
        var id string
Severity: Minor
Found in listener/druid_endpoint.go - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function DruidHTTPEndpoint has 113 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func DruidHTTPEndpoint(metricsCleanupTTL int, disableHistogram bool, histogram *prometheus.HistogramVec, gauge *prometheus.GaugeVec, dnsCache *cache.Cache) http.HandlerFunc {
    gaugeCleaner := newCleaner(gauge, metricsCleanupTTL)
    return func(w http.ResponseWriter, req *http.Request) {
        var druidData []map[string]interface{}
        var id string
Severity: Major
Found in listener/druid_endpoint.go - About 3 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                        } else { // Single datasource
                        if !disableHistogram {
                            histogram.With(prometheus.Labels{
                                "metric_name": strings.Replace(metric, "/", "-", 3),
                                "service":     strings.Replace(service, "/", "-", 3),
    Severity: Major
    Found in listener/druid_endpoint.go and 1 other location - About 1 hr to fix
    listener/druid_endpoint.go on lines 75..95

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 180.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                            for _, entryDatasource := range arrDatasource {
                            if !disableHistogram {
                                histogram.With(prometheus.Labels{
                                    "metric_name": strings.Replace(metric, "/", "-", 3),
                                    "service":     strings.Replace(service, "/", "-", 3),
    Severity: Major
    Found in listener/druid_endpoint.go and 1 other location - About 1 hr to fix
    listener/druid_endpoint.go on lines 96..116

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 180.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method MetricCollector.Collect has a Cognitive Complexity of 28 (exceeds 20 allowed). Consider refactoring.
    Open

    func (collector *MetricCollector) Collect(ch chan<- prometheus.Metric) {
    ch <- prometheus.MustNewConstMetric(collector.DruidHealthStatus,
        prometheus.CounterValue, GetDruidHealthMetrics())
    for _, data := range GetDruidSegmentData() {
        ch <- prometheus.MustNewConstMetric(collector.DataSourceCount,
    Severity: Minor
    Found in collector/druid.go - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func GetDruidTasksData(pathURL string) TasksInterface {
    kingpin.Parse()
    druidURL := *druid + pathURL
    responseData, err := utils.GetResponse(druidURL, pathURL)
    if err != nil {
    Severity: Major
    Found in collector/druid.go and 1 other location - About 1 hr to fix
    collector/druid.go on lines 90..107

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 162.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    func GetDruidDataSourcesTotalRows(pathURL string) DataSourcesTotalRows {
    kingpin.Parse()
    druidURL := *druid + pathURL
    responseData, err := utils.GetSQLResponse(druidURL, totalRowsSQL)
    if err != nil {
    Severity: Major
    Found in collector/druid.go and 1 other location - About 1 hr to fix
    collector/druid.go on lines 70..87

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 162.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method MetricCollector.Collect has 63 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func (collector *MetricCollector) Collect(ch chan<- prometheus.Metric) {
    ch <- prometheus.MustNewConstMetric(collector.DruidHealthStatus,
        prometheus.CounterValue, GetDruidHealthMetrics())
    for _, data := range GetDruidSegmentData() {
        ch <- prometheus.MustNewConstMetric(collector.DataSourceCount,
    Severity: Minor
    Found in collector/druid.go - About 1 hr to fix

      Function Collector has 59 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func Collector() *MetricCollector {
    return &MetricCollector{
        DruidHealthStatus: prometheus.NewDesc("druid_health_status",
            "Health of Druid, 1 is healthy 0 is not",
            nil, prometheus.Labels{
      Severity: Minor
      Found in collector/druid.go - About 1 hr to fix

        Function DruidHTTPEndpoint has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        func DruidHTTPEndpoint(metricsCleanupTTL int, disableHistogram bool, histogram *prometheus.HistogramVec, gauge *prometheus.GaugeVec, dnsCache *cache.Cache) http.HandlerFunc {
        Severity: Minor
        Found in listener/druid_endpoint.go - About 35 mins to fix

          Function GetHealth has 5 return statements (exceeds 4 allowed).
          Open

          func GetHealth(url string) float64 {
    kingpin.Parse()
    client, err := generateTLSConfig()
    if err != nil {
        logrus.Errorf("Cannot generate http client: %v", err)
          Severity: Major
          Found in utils/http.go - About 35 mins to fix

            Function GetSQLResponse has 5 return statements (exceeds 4 allowed).
            Open

            func GetSQLResponse(url string, query string) ([]byte, error) {
    kingpin.Parse()
    client, err := generateTLSConfig()
    if err != nil {
        logrus.Errorf("Cannot generate http client: %v", err)
            Severity: Major
            Found in utils/http.go - About 35 mins to fix

              Function generateTLSConfig has 5 return statements (exceeds 4 allowed).
              Open

              func generateTLSConfig() (*http.Client, error) {
    kingpin.Parse()

    if *certFile != "" && *keyFile != "" && *caFile != "" {
        cert, err := tls.LoadX509KeyPair(*certFile, *keyFile)
              Severity: Major
              Found in utils/http.go - About 35 mins to fix
                Severity
                Category
                Status
                Source
                Language