Sign upLogin

oraclekit/chainlink

View on GitHub
Star

Showing 10 of 10 total issues

Class Client has 41 methods (exceeds 20 allowed). Consider refactoring.
Open

class Ethereum::Client

  include HttpClient
  base_uri ENV['ETHEREUM_URL']
Severity: Minor
Found in app/models/ethereum/client.rb - About 5 hrs to fix

    Method sol_signature has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

      def sol_signature(contract_name, json_abi)
    type = ['function', 'constructor'].include?(json_abi['type']) ? 'function' : 'event'
    name = json_abi['name'] || (json_abi['type'] == 'constructor' ? contract_name : nil)
    inputs = json_abi['inputs'].map do |input|
      "#{input['type']}#{(' ' + input['name']) if input['name'].present?}"
    Severity: Minor
    Found in app/models/solidity_client.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method perform has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

      def perform(type, params)
    if adapter = ExternalAdapter.for_type(type)
      adapter
    elsif [CustomExpectation::SCHEMA_NAME, 'custom'].include? type
      CustomExpectation.new(body: params)
    Severity: Minor
    Found in app/models/adapter_builder.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validate_subtasks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

      def validate_subtasks
    subtask_params.each.with_index do |params, index|
      next unless params && type = params[:adapterType]
      subtask = build_subtask type, params, index
    Severity: Minor
    Found in app/models/assignment/request_handler.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Consider simplifying this complex logical expression.
    Open

          if body.present?
        self.address = body['address'] || body['contractAddress']
        self.update_address = body['functionID'] || body['updateAddress'] || body['method']
        self.config_value = body['data'] || body['payload']
        self.payment_amount = (body['paymentAmount'] || body['amount']).to_i
    Severity: Major
    Found in app/models/ethereum/formatted_oracle.rb - About 40 mins to fix

      Method perform has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def perform(previous_snapshot)
    get_adapter_result(previous_snapshot)

    if response.present? && response.errors.blank?
      parse_adapter_response response
      Severity: Minor
      Found in app/models/adapter_snapshot_handler.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method updated_tx has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def updated_tx(params)
    tx.tap do |tx|
      tx.make_mutable!

      tx.gas_limit = params[:gas_limit] if params[:gas_limit].present?
      Severity: Minor
      Found in app/models/ethereum_transaction.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method compare_to_current has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def compare_to_current
    return false if current_value.nil?
    expected_value = cast(expectation.final_value, current_value)

    if expectation.comparison == '==='
      Severity: Minor
      Found in app/models/custom_api_checker.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def get_status(snapshot, previous_snapshot)
    assignment_snapshot = snapshot.assignment_snapshot

    if assignment_snapshot.requester == subtask
      request = assignment_snapshot.request
      Severity: Minor
      Found in app/models/json_receiver.rb and 1 other location - About 15 mins to fix
      app/models/ethereum/log_watcher.rb on lines 25..35

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        def get_status(snapshot, previous_snapshot)
    assignment_snapshot = snapshot.assignment_snapshot

    if assignment_snapshot.requester == subtask
      event = assignment_snapshot.request
      Severity: Minor
      Found in app/models/ethereum/log_watcher.rb and 1 other location - About 15 mins to fix
      app/models/json_receiver.rb on lines 26..36

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language