Showing 8 of 10 total issues
Class Client
has 41 methods (exceeds 20 allowed). Consider refactoring. Open
class Ethereum::Client
include HttpClient
base_uri ENV['ETHEREUM_URL']
Method sol_signature
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def sol_signature(contract_name, json_abi)
type = ['function', 'constructor'].include?(json_abi['type']) ? 'function' : 'event'
name = json_abi['name'] || (json_abi['type'] == 'constructor' ? contract_name : nil)
inputs = json_abi['inputs'].map do |input|
"#{input['type']}#{(' ' + input['name']) if input['name'].present?}"
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method perform
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def perform(type, params)
if adapter = ExternalAdapter.for_type(type)
adapter
elsif [CustomExpectation::SCHEMA_NAME, 'custom'].include? type
CustomExpectation.new(body: params)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate_subtasks
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def validate_subtasks
subtask_params.each.with_index do |params, index|
next unless params && type = params[:adapterType]
subtask = build_subtask type, params, index
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Consider simplifying this complex logical expression. Open
if body.present?
self.address = body['address'] || body['contractAddress']
self.update_address = body['functionID'] || body['updateAddress'] || body['method']
self.config_value = body['data'] || body['payload']
self.payment_amount = (body['paymentAmount'] || body['amount']).to_i
Method perform
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def perform(previous_snapshot)
get_adapter_result(previous_snapshot)
if response.present? && response.errors.blank?
parse_adapter_response response
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method updated_tx
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def updated_tx(params)
tx.tap do |tx|
tx.make_mutable!
tx.gas_limit = params[:gas_limit] if params[:gas_limit].present?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method compare_to_current
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def compare_to_current
return false if current_value.nil?
expected_value = cast(expectation.final_value, current_value)
if expectation.comparison == '==='
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"