Sign upLogin

orange-cloudfoundry/cf-ops-automation

View on GitHub
Star
concourse/tasks/bosh_delete_plan/delete_plan.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
93%

Method has too many lines. [14/10]
Open

  def process
    deployments_file = ENV.fetch('OUTPUT_FILE', File.join('deployments-to-delete', 'file.txt'))

    expected_deployments = @config_repo_deployments.enabled_deployments
    puts "Expected deployments detected: #{expected_deployments}"
Severity: Minor
Found in concourse/tasks/bosh_delete_plan/delete_plan.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for process is too high. [16.52/15]
Open

  def process
    deployments_file = ENV.fetch('OUTPUT_FILE', File.join('deployments-to-delete', 'file.txt'))

    expected_deployments = @config_repo_deployments.enabled_deployments
    puts "Expected deployments detected: #{expected_deployments}"
Severity: Minor
Found in concourse/tasks/bosh_delete_plan/delete_plan.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

DeletePlan#process has approx 14 statements
Open

  def process
Severity: Minor
Found in concourse/tasks/bosh_delete_plan/delete_plan.rb by reek

A method with Too Many Statements is any method that has a large number of lines.

Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.

So the following method would score +6 in Reek's statement-counting algorithm:

def parse(arg, argv, &error)
  if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
    return nil, block, nil                                         # +1
  end
  opt = (val = parse_arg(val, &error))[1]                          # +2
  val = conv_arg(*val)                                             # +3
  if opt and !arg
    argv.shift                                                     # +4
  else
    val[0] = nil                                                   # +5
  end
  val                                                              # +6
end

(You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)

DeletePlan#append_deployment_name_to_file doesn't depend on instance state (maybe move it to another class?)
Open

  def append_deployment_name_to_file(name, deployments_file)
Severity: Minor
Found in concourse/tasks/bosh_delete_plan/delete_plan.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

There are no issues that match your filters.

Category
Status