Sign upLogin

orange-cloudfoundry/cf-ops-automation

View on GitHub
Star
concourse/tasks/resolve_manifest_versions/resolve_manifest_urls.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
98%

ResolveManifestUrls#version_managed_by_coa? is controlled by argument 'expected_coa_version'
Open

    if expected_coa_version != manifest_version
Severity: Minor
Found in concourse/tasks/resolve_manifest_versions/resolve_manifest_urls.rb by reek

Control Parameter is a special case of Control Couple

Example

A simple example would be the "quoted" parameter in the following method:

def write(quoted)
  if quoted
    write_quoted @value
  else
    write_unquoted @value
  end
end

Fixing those problems is out of the scope of this document but an easy solution could be to remove the "write" method alltogether and to move the calls to "writequoted" / "writeunquoted" in the initial caller of "write".

AbstractReleaseUrlResolver#true? doesn't depend on instance state (maybe move it to another class?)
Open

  def true?(object)
Severity: Minor
Found in concourse/tasks/resolve_manifest_versions/resolve_manifest_urls.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

ResolveManifestUrls#extract_release_manifest_info doesn't depend on instance state (maybe move it to another class?)
Open

  def extract_release_manifest_info(release)
Severity: Minor
Found in concourse/tasks/resolve_manifest_versions/resolve_manifest_urls.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

ResolveManifestUrls#extract_version_info doesn't depend on instance state (maybe move it to another class?)
Open

  def extract_version_info(name, all_versions)
Severity: Minor
Found in concourse/tasks/resolve_manifest_versions/resolve_manifest_urls.rb by reek

A Utility Function is any instance method that has no dependency on the state of the instance.

There are no issues that match your filters.

Category
Status