Method has too many lines. [17/10] Open
def insert_iaas_specific_into_init_pipeline_config(ci_deployment_overview_files)
migrated_counter = 0
ci_deployment_overview_files&.each do |ci_deployment_filename|
ci_deployment = YAML.load_file(ci_deployment_filename)
unless ci_deployment- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
Method has too many lines. [15/10] Open
def insert_iaas_specific_pipeline(ci_deployment_overview)
migrated = false
ci_deployment_overview['ci-deployment']&.each do |_, details|
details['pipelines']&.each do |name, pipeline_config|
if name.end_with?('-s3-br-ulpload-generated')- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.
insert_iaas_specific_into_init_pipeline_config has approx 12 statements Open
def insert_iaas_specific_into_init_pipeline_config(ci_deployment_overview_files)- Read upRead up
- Create a ticketCreate a ticket
- Exclude checks
A method with Too Many Statements is any method that has a large number of lines.
Too Many Statements warns about any method that has more than 5 statements. Reek's smell detector for Too Many Statements counts +1 for every simple statement in a method and +1 for every statement within a control structure (if, else, case, when, for, while, until, begin, rescue) but it doesn't count the control structure itself.
So the following method would score +6 in Reek's statement-counting algorithm:
def parse(arg, argv, &error)
if !(val = arg) and (argv.empty? or /\A-/ =~ (val = argv[0]))
return nil, block, nil # +1
end
opt = (val = parse_arg(val, &error))[1] # +2
val = conv_arg(*val) # +3
if opt and !arg
argv.shift # +4
else
val[0] = nil # +5
end
val # +6
end(You might argue that the two assigments within the first @if@ should count as statements, and that perhaps the nested assignment should count as +2.)
Method insert_iaas_specific_pipeline has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def insert_iaas_specific_pipeline(ci_deployment_overview)
migrated = false
ci_deployment_overview['ci-deployment']&.each do |_, details|
details['pipelines']&.each do |name, pipeline_config|
if name.end_with?('-s3-br-ulpload-generated')- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method insert_iaas_specific_into_init_pipeline_config has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def insert_iaas_specific_into_init_pipeline_config(ci_deployment_overview_files)
migrated_counter = 0
ci_deployment_overview_files&.each do |ci_deployment_filename|
ci_deployment = YAML.load_file(ci_deployment_filename)
unless ci_deployment- Read upRead up
- Create a ticketCreate a ticket
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"