orangeeli/patterns

View on GitHub

Showing 13 of 13 total issues

Function exports has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  (()=>{

    "use strict";

    const Step = {
Severity: Major
Found in lib/promise/step.js - About 2 hrs to fix

    Function exports has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      (()=>{
    
        "use strict";
    
        const Context = require("./context"),
    Severity: Major
    Found in lib/promise/chain.js - About 2 hrs to fix

      Function exports has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        (()=>{
          
          "use strict";
      
          return {
      Severity: Minor
      Found in lib/promise/context.js - About 1 hr to fix

        Function exports has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          (()=>{
        
            "use strict";
        
            const Context = require("./context"),
        Severity: Minor
        Found in lib/promise/chain.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Unexpected require().
        Open

          const gulp = require('gulp'),
        Severity: Minor
        Found in gulpfile.js by eslint

        Enforce require() on the top-level module scope (global-require)

        In Node.js, module dependencies are included using the require() function, such as:

        var fs = require("fs");

        While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

        function foo() {
        
            if (condition) {
                var fs = require("fs");
            }
        }

        Since require() does a synchronous load, it can cause performance problems when used in other locations.

        Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

        Rule Details

        This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

        Examples of incorrect code for this rule:

        /*eslint global-require: "error"*/
        /*eslint-env es6*/
        
        // calling require() inside of a function is not allowed
        function readFile(filename, callback) {
            var fs = require('fs');
            fs.readFile(filename, callback)
        }
        
        // conditional requires like this are also not allowed
        if (DEBUG) { require('debug'); }
        
        // a require() in a switch statement is also flagged
        switch(x) { case '1': require('1'); break; }
        
        // you may not require() inside an arrow function body
        var getModule = (name) => require(name);
        
        // you may not require() inside of a function body as well
        function getModule(name) { return require(name); }
        
        // you may not require() inside of a try/catch block
        try {
            require(unsafeModule);
        } catch(e) {
            console.log(e);
        }

        Examples of correct code for this rule:

        /*eslint global-require: "error"*/
        
        // all these variations of require() are ok
        require('x');
        var y = require('y');
        var z;
        z = require('z').initialize();
        
        // requiring a module and using it in a function is ok
        var fs = require('fs');
        function readFile(filename, callback) {
            fs.readFile(filename, callback)
        }
        
        // you can use a ternary to determine which module to require
        var logger = DEBUG ? require('dev-logger') : require('logger');
        
        // if you want you can require() at the end of your module
        function doSomethingA() {}
        function doSomethingB() {}
        var x = require("x"),
            z = require("z");

        When Not To Use It

        If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

        Don't use process.exit(); throw an error instead.
        Open

                  process.exit(1);
        Severity: Minor
        Found in gulpfile.js by eslint

        Disallow process.exit() (no-process-exit)

        The process.exit() method in Node.js is used to immediately stop the Node.js process and exit. This is a dangerous operation because it can occur in any method at any point in time, potentially stopping a Node.js application completely when an error occurs. For example:

        if (somethingBadHappened) {
            console.error("Something bad happened!");
            process.exit(1);
        }

        This code could appear in any module and will stop the entire application when somethingBadHappened is truthy. This doesn't give the application any chance to respond to the error. It's usually better to throw an error and allow the application to handle it appropriately:

        if (somethingBadHappened) {
            throw new Error("Something bad happened!");
        }

        By throwing an error in this way, other parts of the application have an opportunity to handle the error rather than stopping the application altogether. If the error bubbles all the way up to the process without being handled, then the process will exit and a non-zero exit code will returned, so the end result is the same.

        Rule Details

        This rule aims to prevent the use of process.exit() in Node.js JavaScript. As such, it warns whenever process.exit() is found in code.

        Examples of incorrect code for this rule:

        /*eslint no-process-exit: "error"*/
        
        process.exit(1);
        process.exit(0);

        Examples of correct code for this rule:

        /*eslint no-process-exit: "error"*/
        
        Process.exit();
        var exit = process.exit;

        When Not To Use It

        There may be a part of a Node.js application that is responsible for determining the correct exit code to return upon exiting. In that case, you should turn this rule off to allow proper handling of the exit code. Source: http://eslint.org/docs/rules/

        Unexpected require().
        Open

              Step = require("./step");
        Severity: Minor
        Found in lib/promise/chain.js by eslint

        Enforce require() on the top-level module scope (global-require)

        In Node.js, module dependencies are included using the require() function, such as:

        var fs = require("fs");

        While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

        function foo() {
        
            if (condition) {
                var fs = require("fs");
            }
        }

        Since require() does a synchronous load, it can cause performance problems when used in other locations.

        Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

        Rule Details

        This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

        Examples of incorrect code for this rule:

        /*eslint global-require: "error"*/
        /*eslint-env es6*/
        
        // calling require() inside of a function is not allowed
        function readFile(filename, callback) {
            var fs = require('fs');
            fs.readFile(filename, callback)
        }
        
        // conditional requires like this are also not allowed
        if (DEBUG) { require('debug'); }
        
        // a require() in a switch statement is also flagged
        switch(x) { case '1': require('1'); break; }
        
        // you may not require() inside an arrow function body
        var getModule = (name) => require(name);
        
        // you may not require() inside of a function body as well
        function getModule(name) { return require(name); }
        
        // you may not require() inside of a try/catch block
        try {
            require(unsafeModule);
        } catch(e) {
            console.log(e);
        }

        Examples of correct code for this rule:

        /*eslint global-require: "error"*/
        
        // all these variations of require() are ok
        require('x');
        var y = require('y');
        var z;
        z = require('z').initialize();
        
        // requiring a module and using it in a function is ok
        var fs = require('fs');
        function readFile(filename, callback) {
            fs.readFile(filename, callback)
        }
        
        // you can use a ternary to determine which module to require
        var logger = DEBUG ? require('dev-logger') : require('logger');
        
        // if you want you can require() at the end of your module
        function doSomethingA() {}
        function doSomethingB() {}
        var x = require("x"),
            z = require("z");

        When Not To Use It

        If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

        Unexpected require().
        Open

            mocha = require('gulp-mocha');
        Severity: Minor
        Found in gulpfile.js by eslint

        Enforce require() on the top-level module scope (global-require)

        In Node.js, module dependencies are included using the require() function, such as:

        var fs = require("fs");

        While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

        function foo() {
        
            if (condition) {
                var fs = require("fs");
            }
        }

        Since require() does a synchronous load, it can cause performance problems when used in other locations.

        Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

        Rule Details

        This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

        Examples of incorrect code for this rule:

        /*eslint global-require: "error"*/
        /*eslint-env es6*/
        
        // calling require() inside of a function is not allowed
        function readFile(filename, callback) {
            var fs = require('fs');
            fs.readFile(filename, callback)
        }
        
        // conditional requires like this are also not allowed
        if (DEBUG) { require('debug'); }
        
        // a require() in a switch statement is also flagged
        switch(x) { case '1': require('1'); break; }
        
        // you may not require() inside an arrow function body
        var getModule = (name) => require(name);
        
        // you may not require() inside of a function body as well
        function getModule(name) { return require(name); }
        
        // you may not require() inside of a try/catch block
        try {
            require(unsafeModule);
        } catch(e) {
            console.log(e);
        }

        Examples of correct code for this rule:

        /*eslint global-require: "error"*/
        
        // all these variations of require() are ok
        require('x');
        var y = require('y');
        var z;
        z = require('z').initialize();
        
        // requiring a module and using it in a function is ok
        var fs = require('fs');
        function readFile(filename, callback) {
            fs.readFile(filename, callback)
        }
        
        // you can use a ternary to determine which module to require
        var logger = DEBUG ? require('dev-logger') : require('logger');
        
        // if you want you can require() at the end of your module
        function doSomethingA() {}
        function doSomethingB() {}
        var x = require("x"),
            z = require("z");

        When Not To Use It

        If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

        Unexpected require().
        Open

            const Context = require("./context"),
        Severity: Minor
        Found in lib/promise/chain.js by eslint

        Enforce require() on the top-level module scope (global-require)

        In Node.js, module dependencies are included using the require() function, such as:

        var fs = require("fs");

        While require() may be called anywhere in code, some style guides prescribe that it should be called only in the top level of a module to make it easier to identify dependencies. For instance, it's arguably harder to identify dependencies when they are deeply nested inside of functions and other statements:

        function foo() {
        
            if (condition) {
                var fs = require("fs");
            }
        }

        Since require() does a synchronous load, it can cause performance problems when used in other locations.

        Further, ES6 modules mandate that import and export statements can only occur in the top level of the module's body.

        Rule Details

        This rule requires all calls to require() to be at the top level of the module, similar to ES6 import and export statements, which also can occur only at the top level.

        Examples of incorrect code for this rule:

        /*eslint global-require: "error"*/
        /*eslint-env es6*/
        
        // calling require() inside of a function is not allowed
        function readFile(filename, callback) {
            var fs = require('fs');
            fs.readFile(filename, callback)
        }
        
        // conditional requires like this are also not allowed
        if (DEBUG) { require('debug'); }
        
        // a require() in a switch statement is also flagged
        switch(x) { case '1': require('1'); break; }
        
        // you may not require() inside an arrow function body
        var getModule = (name) => require(name);
        
        // you may not require() inside of a function body as well
        function getModule(name) { return require(name); }
        
        // you may not require() inside of a try/catch block
        try {
            require(unsafeModule);
        } catch(e) {
            console.log(e);
        }

        Examples of correct code for this rule:

        /*eslint global-require: "error"*/
        
        // all these variations of require() are ok
        require('x');
        var y = require('y');
        var z;
        z = require('z').initialize();
        
        // requiring a module and using it in a function is ok
        var fs = require('fs');
        function readFile(filename, callback) {
            fs.readFile(filename, callback)
        }
        
        // you can use a ternary to determine which module to require
        var logger = DEBUG ? require('dev-logger') : require('logger');
        
        // if you want you can require() at the end of your module
        function doSomethingA() {}
        function doSomethingB() {}
        var x = require("x"),
            z = require("z");

        When Not To Use It

        If you have a module that must be initialized with information that comes from the file-system or if a module is only used in very rare situations and will cause significant overhead to load it may make sense to disable the rule. If you need to require() an optional dependency inside of a try/catch, you can disable this rule for just that dependency using the // eslint-disable-line global-require comment. Source: http://eslint.org/docs/rules/

        TODO found
        Open

            // TODO implement rejection
        Severity: Minor
        Found in lib/promise/chain.js by fixme

        TODO found
        Open

            // TODO steps should have a resolve and a reject method
        Severity: Minor
        Found in lib/promise/chain.js by fixme

        TODO found
        Open

            // TODO transform this project into a npm module with a well known api and explain which issue is trying to solve
        Severity: Minor
        Found in lib/promise/chain.js by fixme

        TODO found
        Open

            // TODO use promises on process to return the results
        Severity: Minor
        Found in lib/promise/chain.js by fixme
        Severity
        Category
        Status
        Source
        Language