orca-services/nova-api-php

View on GitHub
src/Method/NovaCreateOffersMethod.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method createRequestBody has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function createRequestBody(NovaCreateOffersParameter $parameter): string
    {
        $dom = new DOMDocument('1.0', 'utf-8');
        $dom->formatOutput = true;

Severity: Major
Found in src/Method/NovaCreateOffersMethod.php - About 2 hrs to fix

    Method createResult has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function createResult(XmlDocument $xml): NovaCreateOffersResult
        {
            $result = new NovaCreateOffersResult();
    
            $xml = $xml->withoutNamespaces();
    Severity: Minor
    Found in src/Method/NovaCreateOffersMethod.php - About 1 hr to fix

      Function createRequestBody has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function createRequestBody(NovaCreateOffersParameter $parameter): string
          {
              $dom = new DOMDocument('1.0', 'utf-8');
              $dom->formatOutput = true;
      
      
      Severity: Minor
      Found in src/Method/NovaCreateOffersMethod.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The class NovaCreateOffersMethod has a coupling between objects value of 13. Consider to reduce the number of dependencies under 13.
      Open

      final class NovaCreateOffersMethod implements NovaMethod
      {
          /**
           * @var NovaApiSoapAction
           */
      Severity: Minor
      Found in src/Method/NovaCreateOffersMethod.php by phpmd

      CouplingBetweenObjects

      Since: 1.1.0

      A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

      Example

      class Foo {
          /**
           * @var \foo\bar\X
           */
          private $x = null;
      
          /**
           * @var \foo\bar\Y
           */
          private $y = null;
      
          /**
           * @var \foo\bar\Z
           */
          private $z = null;
      
          public function setFoo(\Foo $foo) {}
          public function setBar(\Bar $bar) {}
          public function setBaz(\Baz $baz) {}
      
          /**
           * @return \SplObjectStorage
           * @throws \OutOfRangeException
           * @throws \InvalidArgumentException
           * @throws \ErrorException
           */
          public function process(\Iterator $it) {}
      
          // ...
      }

      Source https://phpmd.org/rules/design.html#couplingbetweenobjects

      Avoid using static access to class '\OrcaServices\NovaApi\Xml\XmlDocument' in method 'createOffers'.
      Open

                  $xml = XmlDocument::createFromXmlString($xmlContent);
      Severity: Minor
      Found in src/Method/NovaCreateOffersMethod.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      The method createRequestBody uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
                  // without tkid, search with personal information
                  $withoutTkid = $dom->createElement('ns18:ohneTkid');
                  $traveller->appendChild($withoutTkid);
      
      
      Severity: Minor
      Found in src/Method/NovaCreateOffersMethod.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Similar blocks of code found in 9 locations. Consider refactoring.
      Open

          public function createOffers(NovaCreateOffersParameter $parameter): NovaCreateOffersResult
          {
              // The SOAP endpoint url
              $url = $this->novaSoapAction->getNovaSalesServiceUrl();
      
      
      Severity: Major
      Found in src/Method/NovaCreateOffersMethod.php and 8 other locations - About 2 hrs to fix
      src/Method/CheckSwissPassValidityMethod.php on lines 62..82
      src/Method/NovaConfirmReceiptsMethod.php on lines 67..86
      src/Method/NovaCreateReceiptsMethod.php on lines 67..86
      src/Method/NovaCreateServicesMethod.php on lines 70..89
      src/Method/NovaPurchaseServicesMethod.php on lines 70..89
      src/Method/NovaSavCreateOffersMethod.php on lines 66..85
      src/Method/NovaSearchPartnerMethod.php on lines 68..88
      src/Method/NovaSearchServicesMethod.php on lines 64..83

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 122.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status