Sign upLogin

orca-services/nova-api-php

View on GitHub
Star
src/Method/NovaCreateServicesMethod.php

Summary

Maintainability
D
2 days
Test Coverage

Method createRequestBody has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function createRequestBody(NovaCreateServicesParameter $parameter): string
    {
        $dom = new DOMDocument('1.0', 'utf-8');
        $dom->formatOutput = true;
Severity: Major
Found in src/Method/NovaCreateServicesMethod.php - About 2 hrs to fix

    Avoid using static access to class '\OrcaServices\NovaApi\Xml\XmlDocument' in method 'createService'.
    Open

                $xml = XmlDocument::createFromXmlString($xmlContent);
    Severity: Minor
    Found in src/Method/NovaCreateServicesMethod.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        private function createResult(XmlDocument $xml): NovaCreateServicesResult
    {
        $result = new NovaCreateServicesResult();

        $xml = $xml->withoutNamespaces();
    Severity: Major
    Found in src/Method/NovaCreateServicesMethod.php and 2 other locations - About 1 day to fix
    src/Method/NovaCreateReceiptsMethod.php on lines 141..180
    src/Method/NovaPurchaseServicesMethod.php on lines 158..197

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 292.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 9 locations. Consider refactoring.
    Open

        public function createService(NovaCreateServicesParameter $parameter): NovaCreateServicesResult
    {
        // The SOAP endpoint url
        $url = $this->novaSoapAction->getNovaSalesServiceUrl();
    Severity: Major
    Found in src/Method/NovaCreateServicesMethod.php and 8 other locations - About 2 hrs to fix
    src/Method/CheckSwissPassValidityMethod.php on lines 62..82
    src/Method/NovaConfirmReceiptsMethod.php on lines 67..86
    src/Method/NovaCreateOffersMethod.php on lines 68..87
    src/Method/NovaCreateReceiptsMethod.php on lines 67..86
    src/Method/NovaPurchaseServicesMethod.php on lines 70..89
    src/Method/NovaSavCreateOffersMethod.php on lines 66..85
    src/Method/NovaSearchPartnerMethod.php on lines 68..88
    src/Method/NovaSearchServicesMethod.php on lines 64..83

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 122.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if ($parameter->country && $parameter->postalCode) {
            $addressSaleParameter = $dom->createElement('ns18:verkaufsParameter');
            $serviceRequest->appendChild($addressSaleParameter);
            $addressSaleParameter->setAttribute('ns18:code', 'ADRESSE');
    Severity: Major
    Found in src/Method/NovaCreateServicesMethod.php and 1 other location - About 1 hr to fix
    src/Method/NovaCreateServicesMethod.php on lines 154..165

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 116.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            if ($parameter->lastName && $parameter->firstName) {
            $customerSaleParameter = $dom->createElement('ns18:verkaufsParameter');
            $serviceRequest->appendChild($customerSaleParameter);
            $customerSaleParameter->setAttribute('ns18:code', 'KUNDENNAME');
    Severity: Major
    Found in src/Method/NovaCreateServicesMethod.php and 1 other location - About 1 hr to fix
    src/Method/NovaCreateServicesMethod.php on lines 141..152

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 116.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid excessively long variable names like $customerSaleParameter. Keep variable name length under 20.
    Open

                $customerSaleParameter = $dom->createElement('ns18:verkaufsParameter');
    Severity: Minor
    Found in src/Method/NovaCreateServicesMethod.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

    Source https://phpmd.org/rules/naming.html#longvariable

    There are no issues that match your filters.

    Category
    Status