Sign upLogin

orgsync/jquery-aria

View on GitHub
Star

Showing 7 of 7 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      if ($.isFunction(value)) {
        return this.each(function(i) {
          elem = $(this);
          elem.removeRole(value.call(this, i, elem.attr('role')));
        });
Severity: Major
Found in src/jquery.aria.js and 1 other location - About 1 hr to fix
src/jquery.aria.js on lines 202..207

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      if ($.isFunction(value)) {
        return this.each(function(i) {
          elem = $(this);
          elem.addRole(value.call(this, i, elem.attr('role')));
        });
Severity: Major
Found in src/jquery.aria.js and 1 other location - About 1 hr to fix
src/jquery.aria.js on lines 300..305

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      for(i = this.length - 1; i >= 0; --i) {
        $.removeAria.apply($, [this[i]].concat(args));
      }
Severity: Major
Found in src/jquery.aria.js and 1 other location - About 1 hr to fix
src/jquery.aria.js on lines 148..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for(i = this.length - 1; i >= 0; --i) {
          $.aria.apply($, [this[i]].concat(args));
        }
Severity: Major
Found in src/jquery.aria.js and 1 other location - About 1 hr to fix
src/jquery.aria.js on lines 174..176

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 59.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function removeRole has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    removeRole: function(value) {
      var i, elem, current_roles, roles, j;

      if (arguments.length === 0) {
        for (i = this.length - 1; i >= 0; --i) {
Severity: Minor
Found in src/jquery.aria.js - About 1 hr to fix

    Function addRole has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        addRole: function(value) {
      var roles, i, elem, current_roles, j, roles_length;

      if ($.isFunction(value)) {
        return this.each(function(i) {
    Severity: Minor
    Found in src/jquery.aria.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                    if (current_roles.indexOf(' ' + roles[j] + ' ') < 0) {
                current_roles += roles[j] + ' ';
              }
      Severity: Major
      Found in src/jquery.aria.js - About 45 mins to fix
        Severity
        Category
        Status
        Source
        Language