Sign upLogin

orkungursel/go-eco

View on GitHub
Star
eco.go

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Method eco.bindStructValues has a Cognitive Complexity of 40 (exceeds 20 allowed). Consider refactoring.
Invalid

func (e *eco) bindStructValues(s interface{}, envNameParts ...string) error {
    sr := e.getStructReflection(s)

    for i := 0; i < sr.Type().NumField(); i++ {
        field := sr.Field(i)
Severity: Minor
Found in eco.go - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method eco.convertStrToFieldVal has 102 lines of code (exceeds 50 allowed). Consider refactoring.
Invalid

func (e *eco) convertStrToFieldVal(ref reflect.Value, index int, val interface{}) (out reflect.Value, err error) {
    field := ref.Field(index)
    typeField := ref.Type().Field(index)
    isPtr := typeField.Type.Kind() == reflect.Ptr
Severity: Major
Found in eco.go - About 3 hrs to fix

    Method eco.convertStrToFieldVal has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
    Invalid

    func (e *eco) convertStrToFieldVal(ref reflect.Value, index int, val interface{}) (out reflect.Value, err error) {
    field := ref.Field(index)
    typeField := ref.Type().Field(index)
    isPtr := typeField.Type.Kind() == reflect.Ptr
    Severity: Minor
    Found in eco.go - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method eco.bindStructValues has 63 lines of code (exceeds 50 allowed). Consider refactoring.
    Invalid

    func (e *eco) bindStructValues(s interface{}, envNameParts ...string) error {
    sr := e.getStructReflection(s)

    for i := 0; i < sr.Type().NumField(); i++ {
        field := sr.Field(i)
    Severity: Minor
    Found in eco.go - About 1 hr to fix

      Method eco.convertStrToFieldVal has 5 return statements (exceeds 4 allowed).
      Invalid

      func (e *eco) convertStrToFieldVal(ref reflect.Value, index int, val interface{}) (out reflect.Value, err error) {
    field := ref.Field(index)
    typeField := ref.Type().Field(index)
    isPtr := typeField.Type.Kind() == reflect.Ptr
      Severity: Major
      Found in eco.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Invalid

                case reflect.Float64:
            val = strings.Split(val.(string), e.sliceSeparator)
            var vals []float64
            for _, v := range val.([]string) {
                f, err := strconv.ParseFloat(strings.TrimSpace(v), 64)
        Severity: Minor
        Found in eco.go and 1 other location - About 50 mins to fix
        eco.go on lines 308..319

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 121.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Invalid

                case reflect.Float32:
            val = strings.Split(val.(string), e.sliceSeparator)
            var vals []float32
            for _, v := range val.([]string) {
                f, err := strconv.ParseFloat(strings.TrimSpace(v), 32)
        Severity: Minor
        Found in eco.go and 1 other location - About 50 mins to fix
        eco.go on lines 320..330

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 121.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status