ory-am/hydra

Method Handler.CreateClient has 7 return statements (exceeds 4 allowed).

Open

func (h *Handler) CreateClient(r *http.Request, validator func(context.Context, *Client) error, isDynamic bool) (*Client, error) {
    var c Client
    if err := json.NewDecoder(r.Body).Decode(&c); err != nil {
        return nil, errorsx.WithStack(herodot.ErrBadRequest.WithReasonf("Unable to decode the request body: %s", err))
    }

Method Handler.setOidcDynamicClient has 6 return statements (exceeds 4 allowed).

Open

func (h *Handler) setOidcDynamicClient(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
    if err := h.requireDynamicAuth(r); err != nil {
        h.r.Writer().WriteError(w, r, err)
        return
    }

Method Handler.ValidDynamicAuth has 5 return statements (exceeds 4 allowed).

Open

func (h *Handler) ValidDynamicAuth(r *http.Request, ps httprouter.Params) (fosite.Client, error) {
    c, err := h.r.ClientManager().GetConcreteClient(r.Context(), ps.ByName("id"))
    if err != nil {
        return nil, herodot.ErrUnauthorized.
            WithTrace(err).

Similar blocks of code found in 3 locations. Consider refactoring.

Open

func (h *Handler) deleteOAuth2Client(w http.ResponseWriter, r *http.Request, ps httprouter.Params) {
    var id = ps.ByName("id")
    if err := h.r.ClientManager().DeleteClient(r.Context(), id); err != nil {
        h.r.Writer().WriteError(w, r, err)
        return

• Read up
  Read up