ory-am/hydra

View on GitHub
client/handler_test.go

Summary

Maintainability
F
3 days
Test Coverage

Function TestHandler has 500 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestHandler(t *testing.T) {
    ctx := context.Background()
    reg := internal.NewMockedRegistry(t, &contextx.Default{})
    h := client.NewHandler(reg)
    reg.WithContextualizer(&contextx.TestContextualizer{})
Severity: Major
Found in client/handler_test.go - About 2 days to fix

    Function TestHandler has a Cognitive Complexity of 48 (exceeds 20 allowed). Consider refactoring.
    Open

    func TestHandler(t *testing.T) {
        ctx := context.Background()
        reg := internal.NewMockedRegistry(t, &contextx.Default{})
        h := client.NewHandler(reg)
        reg.WithContextualizer(&contextx.TestContextualizer{})
    Severity: Minor
    Found in client/handler_test.go - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File handler_test.go has 540 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    // Copyright © 2022 Ory Corp
    // SPDX-License-Identifier: Apache-2.0
    
    package client_test
    
    
    Severity: Minor
    Found in client/handler_test.go - About 2 hrs to fix

      Function TestHandler has 7 return statements (exceeds 4 allowed).
      Open

      func TestHandler(t *testing.T) {
          ctx := context.Background()
          reg := internal.NewMockedRegistry(t, &contextx.Default{})
          h := client.NewHandler(reg)
          reg.WithContextualizer(&contextx.TestContextualizer{})
      Severity: Major
      Found in client/handler_test.go - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status