Sign upLogin

ory-am/hydra

View on GitHub
Star
cmd/cmd_perform_authorization_code.go

Summary

Maintainability
D
2 days
Test Coverage

Function NewPerformAuthorizationCodeCmd has 165 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func NewPerformAuthorizationCodeCmd() *cobra.Command {
    cmd := &cobra.Command{
        Use:     "authorization-code",
        Example: "{{ .CommandPath }} --client-id ... --client-secret ...",
        Short:   "Example OAuth 2.0 Client performing the OAuth 2.0 Authorize Code Flow",
Severity: Major
Found in cmd/cmd_perform_authorization_code.go - About 5 hrs to fix

    File cmd_perform_authorization_code.go has 575 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    // Copyright © 2022 Ory Corp
// SPDX-License-Identifier: Apache-2.0

package cmd
    Severity: Minor
    Found in cmd/cmd_perform_authorization_code.go - About 3 hrs to fix

      Function NewPerformAuthorizationCodeCmd has a Cognitive Complexity of 41 (exceeds 20 allowed). Consider refactoring.
      Open

      func NewPerformAuthorizationCodeCmd() *cobra.Command {
    cmd := &cobra.Command{
        Use:     "authorization-code",
        Example: "{{ .CommandPath }} --client-id ... --client-secret ...",
        Short:   "Example OAuth 2.0 Client performing the OAuth 2.0 Authorize Code Flow",
      Severity: Minor
      Found in cmd/cmd_perform_authorization_code.go - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method router.consentGET has 69 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func (rt *router) consentGET(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
    req, raw, err := rt.cl.OAuth2API.GetOAuth2ConsentRequest(r.Context()).
        ConsentChallenge(r.URL.Query().Get("consent_challenge")).
        Execute()
    if err != nil {
      Severity: Minor
      Found in cmd/cmd_perform_authorization_code.go - About 1 hr to fix

        Method router.callback has 51 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func (rt *router) callback(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
    if len(r.URL.Query().Get("error")) > 0 {
        _, _ = fmt.Fprintf(rt.cmd.ErrOrStderr(), "Got error: %s\n", r.URL.Query().Get("error_description"))

        w.WriteHeader(http.StatusInternalServerError)
        Severity: Minor
        Found in cmd/cmd_perform_authorization_code.go - About 1 hr to fix

          Function NewPerformAuthorizationCodeCmd has 8 return statements (exceeds 4 allowed).
          Open

          func NewPerformAuthorizationCodeCmd() *cobra.Command {
    cmd := &cobra.Command{
        Use:     "authorization-code",
        Example: "{{ .CommandPath }} --client-id ... --client-secret ...",
        Short:   "Example OAuth 2.0 Client performing the OAuth 2.0 Authorize Code Flow",
          Severity: Major
          Found in cmd/cmd_perform_authorization_code.go - About 50 mins to fix

            Method router.consentGET has 6 return statements (exceeds 4 allowed).
            Open

            func (rt *router) consentGET(w http.ResponseWriter, r *http.Request, _ httprouter.Params) {
    req, raw, err := rt.cl.OAuth2API.GetOAuth2ConsentRequest(r.Context()).
        ConsentChallenge(r.URL.Query().Get("consent_challenge")).
        Execute()
    if err != nil {
            Severity: Major
            Found in cmd/cmd_perform_authorization_code.go - About 40 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  case "deny":
        req, res, err := rt.cl.OAuth2API.RejectOAuth2ConsentRequest(r.Context()).
            ConsentChallenge(r.FormValue("cs")).
            Execute()
        if err != nil {
              Severity: Minor
              Found in cmd/cmd_perform_authorization_code.go and 1 other location - About 55 mins to fix
              cmd/cmd_perform_authorization_code.go on lines 433..440

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 124.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  case "deny":
        req, res, err := rt.cl.OAuth2API.RejectOAuth2LoginRequest(r.Context()).LoginChallenge(r.FormValue("ls")).Execute()
        if err != nil {
            http.Error(w, err.Error(), http.StatusInternalServerError)
            return
              Severity: Minor
              Found in cmd/cmd_perform_authorization_code.go and 1 other location - About 55 mins to fix
              cmd/cmd_perform_authorization_code.go on lines 552..561

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 124.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status