Sign upLogin

ory-am/hydra

View on GitHub
Star
cmd/server/handler.go

Summary

Maintainability
D
1 day
Test Coverage

Function setup has 97 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func setup(ctx context.Context, d driver.Registry, cmd *cobra.Command) (admin *httprouterx.RouterAdmin, public *httprouterx.RouterPublic, adminmw, publicmw *negroni.Negroni) {
    fmt.Println(banner(config.Version))

    if d.Config().CGroupsV1AutoMaxProcsEnabled() {
        _, err := maxprocs.Set(maxprocs.Logger(d.Logger().Infof))
Severity: Major
Found in cmd/server/handler.go - About 2 hrs to fix

    Function serve has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        ctx context.Context,
    d driver.Registry,
    cmd *cobra.Command,
    wg *sync.WaitGroup,
    iface config.ServeInterface,
    Severity: Major
    Found in cmd/server/handler.go - About 1 hr to fix

      Function EnhanceMiddleware has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

      func EnhanceMiddleware(ctx context.Context, sl *servicelocatorx.Options, d driver.Registry, n *negroni.Negroni, address string, router *httprouter.Router, iface config.ServeInterface) http.Handler {
      Severity: Major
      Found in cmd/server/handler.go - About 50 mins to fix

        Function serve has 6 return statements (exceeds 4 allowed).
        Open

        func serve(
    ctx context.Context,
    d driver.Registry,
    cmd *cobra.Command,
    wg *sync.WaitGroup,
        Severity: Major
        Found in cmd/server/handler.go - About 40 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func RunServePublic(slOpts []servicelocatorx.Option, dOpts []driver.OptionsModifier, cOpts []configx.OptionModifier) func(cmd *cobra.Command, args []string) error {
    return func(cmd *cobra.Command, args []string) error {
        ctx := cmd.Context()
        sl := servicelocatorx.NewOptions(slOpts...)
          Severity: Major
          Found in cmd/server/handler.go and 1 other location - About 5 hrs to fix
          cmd/server/handler.go on lines 80..111

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 373.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          func RunServeAdmin(slOpts []servicelocatorx.Option, dOpts []driver.OptionsModifier, cOpts []configx.OptionModifier) func(cmd *cobra.Command, args []string) error {
    return func(cmd *cobra.Command, args []string) error {
        ctx := cmd.Context()
        sl := servicelocatorx.NewOptions(slOpts...)
          Severity: Major
          Found in cmd/server/handler.go and 1 other location - About 5 hrs to fix
          cmd/server/handler.go on lines 113..144

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 373.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status