Sign upLogin

ory-am/hydra

View on GitHub
Star
consent/handler_test.go

Summary

Maintainability
C
1 day
Test Coverage

Function TestGetConsentRequest has 75 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestGetConsentRequest(t *testing.T) {
    for k, tc := range []struct {
        exists  bool
        handled bool
        status  int
Severity: Minor
Found in consent/handler_test.go - About 2 hrs to fix

    Function TestGetLoginRequest has 57 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestGetLoginRequest(t *testing.T) {
    for k, tc := range []struct {
        exists  bool
        handled bool
        status  int
    Severity: Minor
    Found in consent/handler_test.go - About 1 hr to fix

      Function TestGetLoginRequestWithDuplicateAccept has 52 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func TestGetLoginRequestWithDuplicateAccept(t *testing.T) {
    t.Run("Test get login request with duplicate accept", func(t *testing.T) {
        ctx := context.Background()
        challenge := "challenge"
        requestURL := "http://192.0.2.1"
      Severity: Minor
      Found in consent/handler_test.go - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if tc.handled {
                var result flow.OAuth2RedirectTo
                require.NoError(t, json.NewDecoder(resp.Body).Decode(&result))
                require.Equal(t, requestURL, result.RedirectTo)
            } else if tc.exists {
        Severity: Major
        Found in consent/handler_test.go and 1 other location - About 1 hr to fix
        consent/handler_test.go on lines 135..145

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 182.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if tc.handled {
                var result flow.OAuth2RedirectTo
                require.NoError(t, json.NewDecoder(resp.Body).Decode(&result))
                require.Equal(t, requestURL, result.RedirectTo)
            } else if tc.exists {
        Severity: Major
        Found in consent/handler_test.go and 1 other location - About 1 hr to fix
        consent/handler_test.go on lines 220..230

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 182.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status