Sign upLogin

ory-am/hydra

View on GitHub
Star
consent/test/manager_test_helpers.go

Summary

Maintainability
F
1 wk
Test Coverage

Function ManagerTests has 658 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func ManagerTests(deps Deps, m consent.Manager, clientManager client.Manager, fositeManager x.FositeStorer, network string, parallel bool) func(t *testing.T) {
    lr := make(map[string]*flow.LoginRequest)

    return func(t *testing.T) {
        if parallel {
Severity: Major
Found in consent/test/manager_test_helpers.go - About 3 days to fix

    Function ManagerTests has a Cognitive Complexity of 145 (exceeds 20 allowed). Consider refactoring.
    Open

    func ManagerTests(deps Deps, m consent.Manager, clientManager client.Manager, fositeManager x.FositeStorer, network string, parallel bool) func(t *testing.T) {
    lr := make(map[string]*flow.LoginRequest)

    return func(t *testing.T) {
        if parallel {
    Severity: Minor
    Found in consent/test/manager_test_helpers.go - About 2 days to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File manager_test_helpers.go has 998 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    // Copyright © 2022 Ory Corp
// SPDX-License-Identifier: Apache-2.0

package test
    Severity: Major
    Found in consent/test/manager_test_helpers.go - About 1 day to fix

      Function MockConsentRequest has 68 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      func MockConsentRequest(key string, remember bool, rememberFor int, hasError bool, skip bool, authAt bool, loginChallengeBase string, network string) (c *flow.OAuth2ConsentRequest, h *flow.AcceptOAuth2ConsentRequest, f *flow.Flow) {
    c = &flow.OAuth2ConsentRequest{
        ID:                makeID("challenge", network, key),
        RequestedScope:    []string{"scopea" + key, "scopeb" + key},
        RequestedAudience: []string{"auda" + key, "audb" + key},
      Severity: Minor
      Found in consent/test/manager_test_helpers.go - About 1 hr to fix

        Function TestHelperNID has 52 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        func TestHelperNID(r interface {
    client.ManagerProvider
    FlowCipher() *aead.XChaCha20Poly1305
}, t1ValidNID consent.Manager, t2InvalidNID consent.Manager) func(t *testing.T) {
    testClient := client.Client{ID: "2022-03-11-client-nid-test-1"}
        Severity: Minor
        Found in consent/test/manager_test_helpers.go - About 1 hr to fix

          Function SaneMockHandleConsentRequest has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          func SaneMockHandleConsentRequest(t *testing.T, m consent.Manager, f *flow.Flow, c *flow.OAuth2ConsentRequest, authAt time.Time, rememberFor int, remember bool, hasError bool) *flow.AcceptOAuth2ConsentRequest {
          Severity: Major
          Found in consent/test/manager_test_helpers.go - About 1 hr to fix

            Function MockConsentRequest has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            func MockConsentRequest(key string, remember bool, rememberFor int, hasError bool, skip bool, authAt bool, loginChallengeBase string, network string) (c *flow.OAuth2ConsentRequest, h *flow.AcceptOAuth2ConsentRequest, f *flow.Flow) {
            Severity: Major
            Found in consent/test/manager_test_helpers.go - About 1 hr to fix

              Function ManagerTests has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              func ManagerTests(deps Deps, m consent.Manager, clientManager client.Manager, fositeManager x.FositeStorer, network string, parallel bool) func(t *testing.T) {
              Severity: Minor
              Found in consent/test/manager_test_helpers.go - About 45 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                    if len(tc.challenges) == 0 {
                        assert.EqualError(t, err, consent.ErrNoPreviousConsentFound.Error())
                    } else {
                        require.NoError(t, err)
                        for _, consent := range consents {
                Severity: Minor
                Found in consent/test/manager_test_helpers.go and 1 other location - About 50 mins to fix
                consent/test/manager_test_helpers.go on lines 848..856

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 118.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                    if len(tc.challenges) == 0 {
                        assert.EqualError(t, err, consent.ErrNoPreviousConsentFound.Error())
                    } else {
                        require.NoError(t, err)
                        for _, consent := range consents {
                Severity: Minor
                Found in consent/test/manager_test_helpers.go and 1 other location - About 50 mins to fix
                consent/test/manager_test_helpers.go on lines 806..814

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 118.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status