Sign upLogin

ory-am/hydra

View on GitHub
Star
flow/flow.go

Summary

Maintainability
B
4 hrs
Test Coverage

Method Flow.HandleLoginRequest has 6 return statements (exceeds 4 allowed).
Open

func (f *Flow) HandleLoginRequest(h *HandledLoginRequest) error {
    if f.LoginWasUsed {
        return errors.WithStack(x.ErrConflict.WithHint("The login request was already used and can no longer be changed."))
    }
Severity: Major
Found in flow/flow.go - About 40 mins to fix

    Method Flow.HandleConsentRequest has 5 return statements (exceeds 4 allowed).
    Open

    func (f *Flow) HandleConsentRequest(r *AcceptOAuth2ConsentRequest) error {
    if time.Time(r.HandledAt).IsZero() {
        return errors.New("refusing to handle a consent request with null HandledAt")
    }
    Severity: Major
    Found in flow/flow.go - About 35 mins to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      func (f Flow) ToLoginChallenge(ctx context.Context, cipherProvider CipherProvider) (string, error) {
    if f.Client != nil {
        f.ClientID = f.Client.GetID()
    }
    f.Client = nil
      Severity: Major
      Found in flow/flow.go and 3 other locations - About 40 mins to fix
      flow/flow.go on lines 522..528
      flow/flow.go on lines 531..537
      flow/flow.go on lines 540..546

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 112.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      func (f Flow) ToLoginVerifier(ctx context.Context, cipherProvider CipherProvider) (string, error) {
    if f.Client != nil {
        f.ClientID = f.Client.GetID()
    }
    f.Client = nil
      Severity: Major
      Found in flow/flow.go and 3 other locations - About 40 mins to fix
      flow/flow.go on lines 513..519
      flow/flow.go on lines 531..537
      flow/flow.go on lines 540..546

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 112.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      func (f Flow) ToConsentVerifier(ctx context.Context, cipherProvider CipherProvider) (string, error) {
    if f.Client != nil {
        f.ClientID = f.Client.GetID()
    }
    f.Client = nil
      Severity: Major
      Found in flow/flow.go and 3 other locations - About 40 mins to fix
      flow/flow.go on lines 513..519
      flow/flow.go on lines 522..528
      flow/flow.go on lines 531..537

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 112.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      func (f Flow) ToConsentChallenge(ctx context.Context, cipherProvider CipherProvider) (string, error) {
    if f.Client != nil {
        f.ClientID = f.Client.GetID()
    }
    f.Client = nil
      Severity: Major
      Found in flow/flow.go and 3 other locations - About 40 mins to fix
      flow/flow.go on lines 513..519
      flow/flow.go on lines 522..528
      flow/flow.go on lines 540..546

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 112.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status