Sign upLogin

ory-am/hydra

View on GitHub
Star
internal/httpclient/api_wellknown.go

Summary

Maintainability
C
1 day
Test Coverage

Method WellknownAPIService.DiscoverJsonWebKeysExecute has 62 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (a *WellknownAPIService) DiscoverJsonWebKeysExecute(r ApiDiscoverJsonWebKeysRequest) (*JsonWebKeySet, *http.Response, error) {
    var (
        localVarHTTPMethod  = http.MethodGet
        localVarPostBody    interface{}
        formFiles           []formFile
Severity: Minor
Found in internal/httpclient/api_wellknown.go - About 1 hr to fix

    Method WellknownAPIService.DiscoverJsonWebKeysExecute has 8 return statements (exceeds 4 allowed).
    Open

    func (a *WellknownAPIService) DiscoverJsonWebKeysExecute(r ApiDiscoverJsonWebKeysRequest) (*JsonWebKeySet, *http.Response, error) {
    var (
        localVarHTTPMethod  = http.MethodGet
        localVarPostBody    interface{}
        formFiles           []formFile
    Severity: Major
    Found in internal/httpclient/api_wellknown.go - About 50 mins to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

      func (a *WellknownAPIService) DiscoverJsonWebKeysExecute(r ApiDiscoverJsonWebKeysRequest) (*JsonWebKeySet, *http.Response, error) {
    var (
        localVarHTTPMethod  = http.MethodGet
        localVarPostBody    interface{}
        formFiles           []formFile
      Severity: Major
      Found in internal/httpclient/api_wellknown.go and 3 other locations - About 1 day to fix
      internal/httpclient/api_o_auth2.go on lines 2118..2197
      internal/httpclient/api_oidc.go on lines 439..518
      internal/httpclient/api_oidc.go on lines 670..749

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 643.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status