Sign upLogin

ory-am/hydra

View on GitHub
Star
internal/httpclient/model_introspected_o_auth2_token.go

Summary

Maintainability
C
1 day
Test Coverage

IntrospectedOAuth2Token has 58 methods (exceeds 20 allowed). Consider refactoring.
Open

type IntrospectedOAuth2Token struct {
    // Active is a boolean indicator of whether or not the presented token is currently active.  The specifics of a token's \"active\" state will vary depending on the implementation of the authorization server and the information it keeps about its tokens, but a \"true\" value return for the \"active\" property will generally indicate that a given token has been issued by this authorization server, has not been revoked by the resource owner, and is within its given time window of validity (e.g., after its issuance time and before its expiration time).
    Active bool `json:"active"`
    // Audience contains a list of the token's intended audiences.
    Aud []string `json:"aud,omitempty"`
Severity: Major
Found in internal/httpclient/model_introspected_o_auth2_token.go - About 1 day to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

    func (o *IntrospectedOAuth2Token) UnmarshalJSON(data []byte) (err error) {
    // This validates that all required properties are included in the JSON object
    // by unmarshalling the object into a generic map with string keys and checking
    // that every required field exists as a key in the generic map.
    requiredProperties := []string{
    Severity: Major
    Found in internal/httpclient/model_introspected_o_auth2_token.go and 4 other locations - About 2 hrs to fix
    internal/httpclient/model_accept_o_auth2_login_request.go on lines 382..417
    internal/httpclient/model_generic_error.go on lines 347..382
    internal/httpclient/model_o_auth2_consent_request.go on lines 526..561
    internal/httpclient/model_o_auth2_redirect_to.go on lines 87..122

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 211.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status