Sign upLogin

ory-am/hydra

View on GitHub
Star
jwk/helper_test.go

Summary

Maintainability
C
1 day
Test Coverage

Function TestHandlerFindPublicKey has 61 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestHandlerFindPublicKey(t *testing.T) {
    t.Parallel()

    t.Run("Test_Helper/Run_FindPublicKey_With_RSA", func(t *testing.T) {
        t.Parallel()
Severity: Minor
Found in jwk/helper_test.go - About 1 hr to fix

    Function TestGetOrGenerateKeys has 52 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestGetOrGenerateKeys(t *testing.T) {
    t.Parallel()
    reg := internal.NewMockedRegistry(t, &contextx.Default{})

    setId := uuid.NewUUID().String()
    Severity: Minor
    Found in jwk/helper_test.go - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          t.Run("Test_Helper/Run_PEMBlockForKey_With_EdDSA", func(t *testing.T) {
        EdDSAIDKS, err := jwk.GenerateJWK(context.Background(), jose.EdDSA, "test-id-3", "sig")
        require.NoError(t, err)
        key, err := jwk.FindPrivateKey(EdDSAIDKS)
        require.NoError(t, err)
      Severity: Major
      Found in jwk/helper_test.go and 2 other locations - About 1 hr to fix
      jwk/helper_test.go on lines 155..164
      jwk/helper_test.go on lines 166..175

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 164.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          t.Run("Test_Helper/Run_PEMBlockForKey_With_ECDSA", func(t *testing.T) {
        ECDSAIDKS, err := jwk.GenerateJWK(context.Background(), jose.ES256, "test-id-2", "sig")
        require.NoError(t, err)
        key, err := jwk.FindPrivateKey(ECDSAIDKS)
        require.NoError(t, err)
      Severity: Major
      Found in jwk/helper_test.go and 2 other locations - About 1 hr to fix
      jwk/helper_test.go on lines 155..164
      jwk/helper_test.go on lines 177..186

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 164.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          t.Run("Test_Helper/Run_PEMBlockForKey_With_RSA", func(t *testing.T) {
        RSIDKS, err := jwk.GenerateJWK(context.Background(), jose.RS256, "test-id-1", "sig")
        require.NoError(t, err)
        key, err := jwk.FindPrivateKey(RSIDKS)
        require.NoError(t, err)
      Severity: Major
      Found in jwk/helper_test.go and 2 other locations - About 1 hr to fix
      jwk/helper_test.go on lines 166..175
      jwk/helper_test.go on lines 177..186

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 164.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          t.Run("Test_Helper/Run_FindPublicKey_With_RSA", func(t *testing.T) {
        t.Parallel()
        RSIDKS, err := jwk.GenerateJWK(context.Background(), jose.RS256, "test-id-1", "sig")
        require.NoError(t, err)
        keys, err := jwk.FindPublicKey(RSIDKS)
      Severity: Major
      Found in jwk/helper_test.go and 1 other location - About 1 hr to fix
      jwk/helper_test.go on lines 88..96

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 147.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          t.Run("Test_Helper/Run_FindPublicKey_With_ECDSA", func(t *testing.T) {
        t.Parallel()
        ECDSAIDKS, err := jwk.GenerateJWK(context.Background(), jose.ES256, "test-id-2", "sig")
        require.NoError(t, err)
        keys, err := jwk.FindPublicKey(ECDSAIDKS)
      Severity: Major
      Found in jwk/helper_test.go and 1 other location - About 1 hr to fix
      jwk/helper_test.go on lines 51..59

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 147.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status