Sign upLogin

ory-am/hydra

View on GitHub
Star
jwk/manager_strategy_test.go

Summary

Maintainability
C
1 day
Test Coverage

Function TestKeyManagerStrategy has 164 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestKeyManagerStrategy(t *testing.T) {
    t.Parallel()
    ctrl := gomock.NewController(t)
    softwareKeyManager := NewMockManager(ctrl)
    hardwareKeyManager := NewMockManager(ctrl)
Severity: Major
Found in jwk/manager_strategy_test.go - About 5 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        t.Run("UpdateKeySet_WithError", func(t *testing.T) {
        softwareKeyManager.EXPECT().UpdateKeySet(gomock.Any(), gomock.Eq("set1"), gomock.Any()).Return(errors.New("test"))
        err := keyManager.UpdateKeySet(context.TODO(), "set1", nil)
        assert.Error(t, err, "test")
    })
    Severity: Major
    Found in jwk/manager_strategy_test.go and 3 other locations - About 50 mins to fix
    jwk/manager_strategy_test.go on lines 57..61
    jwk/manager_strategy_test.go on lines 69..73
    jwk/manager_strategy_test.go on lines 81..85

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        t.Run("AddKey_WithError", func(t *testing.T) {
        softwareKeyManager.EXPECT().AddKey(gomock.Any(), gomock.Eq("set1"), gomock.Any()).Return(errors.New("test"))
        err := keyManager.AddKey(context.TODO(), "set1", nil)
        assert.Error(t, err, "test")
    })
    Severity: Major
    Found in jwk/manager_strategy_test.go and 3 other locations - About 50 mins to fix
    jwk/manager_strategy_test.go on lines 69..73
    jwk/manager_strategy_test.go on lines 81..85
    jwk/manager_strategy_test.go on lines 93..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        t.Run("AddKeySet_WithError", func(t *testing.T) {
        softwareKeyManager.EXPECT().AddKeySet(gomock.Any(), gomock.Eq("set1"), gomock.Any()).Return(errors.New("test"))
        err := keyManager.AddKeySet(context.TODO(), "set1", nil)
        assert.Error(t, err, "test")
    })
    Severity: Major
    Found in jwk/manager_strategy_test.go and 3 other locations - About 50 mins to fix
    jwk/manager_strategy_test.go on lines 57..61
    jwk/manager_strategy_test.go on lines 81..85
    jwk/manager_strategy_test.go on lines 93..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        t.Run("UpdateKey_WithError", func(t *testing.T) {
        softwareKeyManager.EXPECT().UpdateKey(gomock.Any(), gomock.Eq("set1"), gomock.Any()).Return(errors.New("test"))
        err := keyManager.UpdateKey(context.TODO(), "set1", nil)
        assert.Error(t, err, "test")
    })
    Severity: Major
    Found in jwk/manager_strategy_test.go and 3 other locations - About 50 mins to fix
    jwk/manager_strategy_test.go on lines 57..61
    jwk/manager_strategy_test.go on lines 69..73
    jwk/manager_strategy_test.go on lines 93..97

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        t.Run("UpdateKey", func(t *testing.T) {
        softwareKeyManager.EXPECT().UpdateKey(gomock.Any(), gomock.Eq("set1"), gomock.Any()).Return(nil)
        err := keyManager.UpdateKey(context.TODO(), "set1", nil)
        assert.NoError(t, err)
    })
    Severity: Major
    Found in jwk/manager_strategy_test.go and 3 other locations - About 40 mins to fix
    jwk/manager_strategy_test.go on lines 51..55
    jwk/manager_strategy_test.go on lines 63..67
    jwk/manager_strategy_test.go on lines 87..91

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        t.Run("AddKeySet", func(t *testing.T) {
        softwareKeyManager.EXPECT().AddKeySet(gomock.Any(), gomock.Eq("set1"), gomock.Any()).Return(nil)
        err := keyManager.AddKeySet(context.TODO(), "set1", nil)
        assert.NoError(t, err)
    })
    Severity: Major
    Found in jwk/manager_strategy_test.go and 3 other locations - About 40 mins to fix
    jwk/manager_strategy_test.go on lines 51..55
    jwk/manager_strategy_test.go on lines 75..79
    jwk/manager_strategy_test.go on lines 87..91

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        t.Run("UpdateKeySet", func(t *testing.T) {
        softwareKeyManager.EXPECT().UpdateKeySet(gomock.Any(), gomock.Eq("set1"), gomock.Any()).Return(nil)
        err := keyManager.UpdateKeySet(context.TODO(), "set1", nil)
        assert.NoError(t, err)
    })
    Severity: Major
    Found in jwk/manager_strategy_test.go and 3 other locations - About 40 mins to fix
    jwk/manager_strategy_test.go on lines 51..55
    jwk/manager_strategy_test.go on lines 63..67
    jwk/manager_strategy_test.go on lines 75..79

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

        t.Run("AddKey", func(t *testing.T) {
        softwareKeyManager.EXPECT().AddKey(gomock.Any(), gomock.Eq("set1"), gomock.Any()).Return(nil)
        err := keyManager.AddKey(context.TODO(), "set1", nil)
        assert.NoError(t, err)
    })
    Severity: Major
    Found in jwk/manager_strategy_test.go and 3 other locations - About 40 mins to fix
    jwk/manager_strategy_test.go on lines 63..67
    jwk/manager_strategy_test.go on lines 75..79
    jwk/manager_strategy_test.go on lines 87..91

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 111.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status