ory-am/hydra

View on GitHub
oauth2/oauth2_client_credentials_bench_test.go

Summary

Maintainability
D
2 days
Test Coverage

Function BenchmarkClientCredentials has 99 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func BenchmarkClientCredentials(b *testing.B) {
    ctx := context.Background()

    spans := tracetest.NewSpanRecorder()
    tracer := trace.NewTracerProvider(trace.WithSpanProcessor(spans)).Tracer("")
Severity: Major
Found in oauth2/oauth2_client_credentials_bench_test.go - About 2 hrs to fix

    Function BenchmarkClientCredentials has 7 return statements (exceeds 4 allowed).
    Open

    func BenchmarkClientCredentials(b *testing.B) {
        ctx := context.Background()
    
        spans := tracetest.NewSpanRecorder()
        tracer := trace.NewTracerProvider(trace.WithSpanProcessor(spans)).Tracer("")
    Severity: Major
    Found in oauth2/oauth2_client_credentials_bench_test.go - About 45 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          var inspectToken = func(b *testing.B, token *goauth2.Token, cl *hc.Client, conf clientcredentials.Config, strategy string, expectedExp time.Time, checkExtraClaims bool) {
              introspection := testhelpers.IntrospectToken(b, &goauth2.Config{ClientID: cl.GetID(), ClientSecret: conf.ClientSecret}, token.AccessToken, admin)
      
              check := func(res gjson.Result) {
                  assert.EqualValues(b, cl.GetID(), res.Get("client_id").String(), "%s", res.Raw)
      Severity: Major
      Found in oauth2/oauth2_client_credentials_bench_test.go and 1 other location - About 1 day to fix
      oauth2/oauth2_client_credentials_test.go on lines 81..116

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 719.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          var newCustomClient = func(b *testing.B, c *hc.Client) (*hc.Client, clientcredentials.Config) {
              unhashedSecret := c.Secret
              require.NoError(b, reg.ClientManager().CreateClient(ctx, c))
              return c, clientcredentials.Config{
                  ClientID:       c.GetID(),
      Severity: Major
      Found in oauth2/oauth2_client_credentials_bench_test.go and 1 other location - About 1 hr to fix
      oauth2/oauth2_client_credentials_test.go on lines 42..52

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 185.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          b.Run("strategy=opaque", func(b *testing.B) {
              initialDBSpans := dbSpans(spans)
              for i := 0; i < b.N; i++ {
                  run("opaque")(b)
              }
      Severity: Major
      Found in oauth2/oauth2_client_credentials_bench_test.go and 1 other location - About 1 hr to fix
      oauth2/oauth2_client_credentials_bench_test.go on lines 134..142

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 165.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          b.Run("strategy=jwt", func(b *testing.B) {
              initialDBSpans := dbSpans(spans)
              for i := 0; i < b.N; i++ {
                  run("jwt")(b)
              }
      Severity: Major
      Found in oauth2/oauth2_client_credentials_bench_test.go and 1 other location - About 1 hr to fix
      oauth2/oauth2_client_credentials_bench_test.go on lines 144..152

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 165.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          var newClient = func(b *testing.B) (*hc.Client, clientcredentials.Config) {
              cc, config := newCustomClient(b, &hc.Client{
                  Secret:        uuid.New().String(),
                  RedirectURIs:  []string{public.URL + "/callback"},
                  ResponseTypes: []string{"token"},
      Severity: Major
      Found in oauth2/oauth2_client_credentials_bench_test.go and 1 other location - About 1 hr to fix
      oauth2/oauth2_client_credentials_test.go on lines 54..64

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 145.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          run := func(strategy string) func(b *testing.B) {
              return func(t *testing.B) {
                  reg.Config().MustSet(ctx, config.KeyAccessTokenStrategy, strategy)
      
                  cl, conf := newClient(b)
      Severity: Major
      Found in oauth2/oauth2_client_credentials_bench_test.go and 1 other location - About 1 hr to fix
      oauth2/oauth2_client_credentials_test.go on lines 139..146

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 133.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          var getAndInspectToken = func(b *testing.B, cl *hc.Client, conf clientcredentials.Config, strategy string, expectedExp time.Time, checkExtraClaims bool) {
              token, err := getToken(b, conf)
              require.NoError(b, err)
              inspectToken(b, token, cl, conf, strategy, expectedExp, checkExtraClaims)
          }
      Severity: Minor
      Found in oauth2/oauth2_client_credentials_bench_test.go and 1 other location - About 35 mins to fix
      oauth2/oauth2_client_credentials_test.go on lines 118..122

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status