Sign upLogin

ory-am/hydra

View on GitHub
Star
oauth2/oauth2_jwt_bearer_test.go

Summary

Maintainability
F
5 days
Test Coverage

Function TestJWTBearer has 432 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestJWTBearer(t *testing.T) {
    ctx := context.Background()
    reg := internal.NewMockedRegistry(t, &contextx.Default{})
    reg.Config().MustSet(ctx, config.KeyAccessTokenStrategy, "opaque")
    _, admin := testhelpers.NewOAuth2Server(ctx, t, reg)
Severity: Major
Found in oauth2/oauth2_jwt_bearer_test.go - About 2 days to fix

    Function TestJWTBearer has 12 return statements (exceeds 4 allowed).
    Open

    func TestJWTBearer(t *testing.T) {
    ctx := context.Background()
    reg := internal.NewMockedRegistry(t, &contextx.Default{})
    reg.Config().MustSet(ctx, config.KeyAccessTokenStrategy, "opaque")
    _, admin := testhelpers.NewOAuth2Server(ctx, t, reg)
    Severity: Major
    Found in oauth2/oauth2_jwt_bearer_test.go - About 1 hr to fix

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          t.Run("should fail token if hook fails", func(t *testing.T) {
        run := func(strategy string) func(t *testing.T) {
            return func(t *testing.T) {
                hs := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
                    w.WriteHeader(http.StatusInternalServerError)
      Severity: Major
      Found in oauth2/oauth2_jwt_bearer_test.go and 2 other locations - About 7 hrs to fix
      oauth2/oauth2_jwt_bearer_test.go on lines 495..528
      oauth2/oauth2_jwt_bearer_test.go on lines 530..563

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 509.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          t.Run("should fail token if hook response is malformed", func(t *testing.T) {
        run := func(strategy string) func(t *testing.T) {
            return func(t *testing.T) {
                hs := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
                    w.WriteHeader(http.StatusOK)
      Severity: Major
      Found in oauth2/oauth2_jwt_bearer_test.go and 2 other locations - About 7 hrs to fix
      oauth2/oauth2_jwt_bearer_test.go on lines 460..493
      oauth2/oauth2_jwt_bearer_test.go on lines 495..528

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 509.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          t.Run("should fail token if hook denied the request", func(t *testing.T) {
        run := func(strategy string) func(t *testing.T) {
            return func(t *testing.T) {
                hs := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
                    w.WriteHeader(http.StatusForbidden)
      Severity: Major
      Found in oauth2/oauth2_jwt_bearer_test.go and 2 other locations - About 7 hrs to fix
      oauth2/oauth2_jwt_bearer_test.go on lines 460..493
      oauth2/oauth2_jwt_bearer_test.go on lines 530..563

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 509.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      token, _, err := signer.Generate(ctx, jwt.MapClaims{
                    "jti": uuid.NewString(),
                    "iss": trustGrant.Issuer,
                    "sub": trustGrant.Subject,
                    "aud": audience,
      Severity: Major
      Found in oauth2/oauth2_jwt_bearer_test.go and 1 other location - About 1 hr to fix
      oauth2/oauth2_jwt_bearer_test.go on lines 385..392

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 146.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                      token, _, err := signer.Generate(ctx, jwt.MapClaims{
                    "jti": uuid.NewString(),
                    "iss": trustGrant.Issuer,
                    "sub": trustGrant.Subject,
                    "aud": audience,
      Severity: Major
      Found in oauth2/oauth2_jwt_bearer_test.go and 1 other location - About 1 hr to fix
      oauth2/oauth2_jwt_bearer_test.go on lines 314..321

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 146.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status