ory-am/hydra

View on GitHub
persistence/sql/persister_consent.go

Summary

Maintainability
D
1 day
Test Coverage

File persister_consent.go has 646 lines of code (exceeds 500 allowed). Consider refactoring.
Open

// Copyright © 2022 Ory Corp
// SPDX-License-Identifier: Apache-2.0

package sql

Severity: Minor
Found in persistence/sql/persister_consent.go - About 5 hrs to fix

    Persister has 36 methods (exceeds 20 allowed). Consider refactoring.
    Open

    func (p *Persister) RevokeSubjectConsentSession(ctx context.Context, user string) error {
        ctx, span := p.r.Tracer(ctx).Tracer().Start(ctx, "persistence.sql.RevokeSubjectConsentSession")
        defer span.End()
    
        return p.Transaction(ctx, p.revokeConsentSession("consent_challenge_id IS NOT NULL AND subject = ?", user))
    Severity: Minor
    Found in persistence/sql/persister_consent.go - About 4 hrs to fix

      Method Persister.ConfirmLoginSession has 7 return statements (exceeds 4 allowed).
      Open

      func (p *Persister) ConfirmLoginSession(ctx context.Context, loginSession *flow.LoginSession) error {
          ctx, span := p.r.Tracer(ctx).Tracer().Start(ctx, "persistence.sql.ConfirmLoginSession")
          defer span.End()
      
          loginSession.NID = p.NetworkID(ctx)
      Severity: Major
      Found in persistence/sql/persister_consent.go - About 45 mins to fix

        Method Persister.VerifyAndInvalidateConsentRequest has 5 return statements (exceeds 4 allowed).
        Open

        func (p *Persister) VerifyAndInvalidateConsentRequest(ctx context.Context, verifier string) (*flow.AcceptOAuth2ConsentRequest, error) {
            ctx, span := p.r.Tracer(ctx).Tracer().Start(ctx, "persistence.sql.VerifyAndInvalidateConsentRequest")
            defer span.End()
        
            f, err := flowctx.Decode[flow.Flow](ctx, p.r.FlowCipher(), verifier, flowctx.AsConsentVerifier)
        Severity: Major
        Found in persistence/sql/persister_consent.go - About 35 mins to fix

          Method Persister.mySQLConfirmLoginSession has 5 return statements (exceeds 4 allowed).
          Open

          func (p *Persister) mySQLConfirmLoginSession(ctx context.Context, session *flow.LoginSession) error {
              err := sqlcon.HandleError(p.Connection(ctx).Create(session))
              if err == nil {
                  return nil
              }
          Severity: Major
          Found in persistence/sql/persister_consent.go - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (p *Persister) ListUserAuthenticatedClientsWithBackChannelLogout(ctx context.Context, subject, sid string) ([]client.Client, error) {
                ctx, span := p.r.Tracer(ctx).Tracer().Start(ctx, "persistence.sql.ListUserAuthenticatedClientsWithBackChannelLogout")
                defer span.End()
                return p.listUserAuthenticatedClients(ctx, subject, sid, "back")
            }
            Severity: Minor
            Found in persistence/sql/persister_consent.go and 1 other location - About 35 mins to fix
            persistence/sql/persister_consent.go on lines 621..626

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            func (p *Persister) ListUserAuthenticatedClientsWithFrontChannelLogout(ctx context.Context, subject, sid string) ([]client.Client, error) {
                ctx, span := p.r.Tracer(ctx).Tracer().Start(ctx, "persistence.sql.ListUserAuthenticatedClientsWithFrontChannelLogout")
                defer span.End()
            
                return p.listUserAuthenticatedClients(ctx, subject, sid, "front")
            Severity: Minor
            Found in persistence/sql/persister_consent.go and 1 other location - About 35 mins to fix
            persistence/sql/persister_consent.go on lines 628..632

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status