Sign upLogin

ory-am/hydra

View on GitHub
Star
x/oauth2cors/cors_test.go

Summary

Maintainability
F
3 days
Test Coverage

Function TestOAuth2AwareCORSMiddleware has 239 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestOAuth2AwareCORSMiddleware(t *testing.T) {
    ctx := context.Background()
    r := internal.NewRegistryMemory(t, internal.NewConfigurationWithDefaults(), &contextx.Default{})
    token, signature, _ := r.OAuth2HMACStrategy().GenerateAccessToken(ctx, nil)
Severity: Major
Found in x/oauth2cors/cors_test.go - About 1 day to fix

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            {
            d: "should accept client origin when basic auth client exists and origin is set at the client as well as the server",
            prep: func(t *testing.T, r driver.Registry) {
                r.Config().MustSet(ctx, "serve.public.cors.enabled", true)
                r.Config().MustSet(ctx, "serve.public.cors.allowed_origins", []string{"http://**.example.com"})
    Severity: Major
    Found in x/oauth2cors/cors_test.go and 4 other locations - About 2 hrs to fix
    x/oauth2cors/cors_test.go on lines 157..169
    x/oauth2cors/cors_test.go on lines 170..182
    x/oauth2cors/cors_test.go on lines 183..195
    x/oauth2cors/cors_test.go on lines 263..275

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 243.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            {
            d: "should accept when basic auth client exists and origin (with full wildcard) is allowed globally",
            prep: func(t *testing.T, r driver.Registry) {
                r.Config().MustSet(ctx, "serve.public.cors.enabled", true)
                r.Config().MustSet(ctx, "serve.public.cors.allowed_origins", []string{"*"})
    Severity: Major
    Found in x/oauth2cors/cors_test.go and 4 other locations - About 2 hrs to fix
    x/oauth2cors/cors_test.go on lines 170..182
    x/oauth2cors/cors_test.go on lines 183..195
    x/oauth2cors/cors_test.go on lines 250..262
    x/oauth2cors/cors_test.go on lines 263..275

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 243.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            {
            d: "should accept when basic auth client exists and origin (with full wildcard) allowed per client",
            prep: func(t *testing.T, r driver.Registry) {
                r.Config().MustSet(ctx, "serve.public.cors.enabled", true)
                r.Config().MustSet(ctx, "serve.public.cors.allowed_origins", []string{"http://not-test-domain.com"})
    Severity: Major
    Found in x/oauth2cors/cors_test.go and 4 other locations - About 2 hrs to fix
    x/oauth2cors/cors_test.go on lines 157..169
    x/oauth2cors/cors_test.go on lines 170..182
    x/oauth2cors/cors_test.go on lines 250..262
    x/oauth2cors/cors_test.go on lines 263..275

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 243.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            {
            d: "should accept when basic auth client exists and origin (with partial wildcard) is allowed globally",
            prep: func(t *testing.T, r driver.Registry) {
                r.Config().MustSet(ctx, "serve.public.cors.enabled", true)
                r.Config().MustSet(ctx, "serve.public.cors.allowed_origins", []string{"http://*.foobar.com"})
    Severity: Major
    Found in x/oauth2cors/cors_test.go and 4 other locations - About 2 hrs to fix
    x/oauth2cors/cors_test.go on lines 157..169
    x/oauth2cors/cors_test.go on lines 183..195
    x/oauth2cors/cors_test.go on lines 250..262
    x/oauth2cors/cors_test.go on lines 263..275

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 243.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

            {
            d: "should accept server origin when basic auth client exists and origin is set at the client as well as the server",
            prep: func(t *testing.T, r driver.Registry) {
                r.Config().MustSet(ctx, "serve.public.cors.enabled", true)
                r.Config().MustSet(ctx, "serve.public.cors.allowed_origins", []string{"http://**.example.com"})
    Severity: Major
    Found in x/oauth2cors/cors_test.go and 4 other locations - About 2 hrs to fix
    x/oauth2cors/cors_test.go on lines 157..169
    x/oauth2cors/cors_test.go on lines 170..182
    x/oauth2cors/cors_test.go on lines 183..195
    x/oauth2cors/cors_test.go on lines 250..262

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 243.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            {
            d: "should accept when basic auth client exists and origin (with partial wildcard) is allowed per client",
            prep: func(t *testing.T, r driver.Registry) {
                r.Config().MustSet(ctx, "serve.public.cors.enabled", true)
                r.Config().MustSet(ctx, "serve.public.cors.allowed_origins", []string{})
    Severity: Major
    Found in x/oauth2cors/cors_test.go and 2 other locations - About 2 hrs to fix
    x/oauth2cors/cors_test.go on lines 118..130
    x/oauth2cors/cors_test.go on lines 144..156

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 241.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            {
            d: "should accept when basic auth client exists and wildcard origin is allowed per client",
            prep: func(t *testing.T, r driver.Registry) {
                r.Config().MustSet(ctx, "serve.public.cors.enabled", true)
                r.Config().MustSet(ctx, "serve.public.cors.allowed_origins", []string{})
    Severity: Major
    Found in x/oauth2cors/cors_test.go and 2 other locations - About 2 hrs to fix
    x/oauth2cors/cors_test.go on lines 118..130
    x/oauth2cors/cors_test.go on lines 131..143

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 241.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            {
            d: "should accept when basic auth client exists and origin allowed",
            prep: func(t *testing.T, r driver.Registry) {
                r.Config().MustSet(ctx, "serve.public.cors.enabled", true)
                r.Config().MustSet(ctx, "serve.public.cors.allowed_origins", []string{})
    Severity: Major
    Found in x/oauth2cors/cors_test.go and 2 other locations - About 2 hrs to fix
    x/oauth2cors/cors_test.go on lines 131..143
    x/oauth2cors/cors_test.go on lines 144..156

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 241.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status