os-js/osjs-client

View on GitHub

Showing 45 of 77 total issues

Function mousedown has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

  mousedown(ev, win) {
    let attributeSet = false;

    const {moveable, resizable} = win.attributes;
    const {maximized} = win.state;
Severity: Minor
Found in src/window-behavior.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File index.d.ts has 874 lines of code (exceeds 600 allowed). Consider refactoring.
Open

/*
 * OS.js - JavaScript Cloud/Web Desktop Platform
 *
 * Copyright (c) Anders Evenrud <andersevenrud@gmail.com>
 * All rights reserved.
Severity: Major
Found in index.d.ts - About 1 day to fix

    Function mousedown has 116 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

      mousedown(ev, win) {
        let attributeSet = false;
    
        const {moveable, resizable} = win.attributes;
        const {maximized} = win.state;
    Severity: Major
    Found in src/window-behavior.js - About 3 hrs to fix

      Function render has 89 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

        render(root) {
          if (!this._render(root)) {
            return;
          }
      
      
      Severity: Major
      Found in src/adapters/ui/iconview.js - About 2 hrs to fix

        Function render has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

          render(root) {
            if (!this._render(root)) {
              return;
            }
        
        
        Severity: Minor
        Found in src/adapters/ui/iconview.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createView has 68 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        const createView = (core, fs, icon, _) => {
          const resultView = ({results, index}, actions) => results.map((r, i) => h('li', {
            onclick: () => actions.open(i),
            onupdate: el => {
              if (i === index) {
        Severity: Major
        Found in src/adapters/ui/search.js - About 1 hr to fix

          Function create has 68 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

          const create = (core, $element) => {
            const _ = core.make('osjs/locale').translate;
            const fs = core.make('osjs/fs');
            const {icon} = core.make('osjs/theme');
            const view = createView(core, fs, icon, _);
          Severity: Major
          Found in src/adapters/ui/search.js - About 1 hr to fix

            Function getDataTransfer has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

            const getDataTransfer = (ev, type, dataTransferProperty) => {
              let files = [];
              let data;
            
              if (ev.dataTransfer) {
            Severity: Minor
            Found in src/utils/dnd.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function sortDefault has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

            const sortDefault = (k, d) => (a, b) =>
              (a[k] < b[k])
                ? -1
                : ((a[k] > b[k])
                  ? (d === 'asc' ? 1 : 0)
            Severity: Minor
            Found in src/utils/vfs.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function view has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

            const view = (computeLabel, fileIcon, themeIcon, droppable) => (state, actions) =>
              h('div', {
                class: 'osjs-desktop-iconview__wrapper',
                oncontextmenu: ev => {
                  if (isRootElement(ev)) {
            Severity: Minor
            Found in src/adapters/ui/iconview.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function start has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

              start() {
                const connect = () => new Promise((resolve, reject) => {
                  try {
                    const valid = this._createConnection(error => error ? reject(error) : resolve());
                    if (valid === false) {
            Severity: Minor
            Found in src/core.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function createView has 61 lines of code (exceeds 50 allowed). Consider refactoring.
            Open

            const createView = (options) => {
              const {src, position} = options.logo;
            
              const logo = () =>
                h('div', {
            Severity: Major
            Found in src/adapters/ui/login.js - About 1 hr to fix

              Function localStorageSettings has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

              const localStorageSettings = (core) => {
                const prefix = core.config('settings.prefix', '');
              
                return {
                  clear(ns) {
              Severity: Minor
              Found in src/adapters/settings/localstorage.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function positionFromGravity has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

              export const positionFromGravity = (win, rect, gravity) => {
                let {left, top} = win.state.position;
              
                if (gravity === 'center') {
                  left = (rect.width / 2) - (win.state.dimension.width / 2);
              Severity: Minor
              Found in src/utils/windows.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function createPackageAvailabilityCheck has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

              export const createPackageAvailabilityCheck = (core) => {
                const user = core.getUser();
                const permissions = core.config('packages.permissions', {});
              
                const checkMetadataGroups = iter => {
              Severity: Minor
              Found in src/utils/packages.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function onContextMenu has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                onContextMenu(ev) {
                  const lockSettings = this.core.config('desktop.lock');
                  const extras = [].concat(...this.contextmenuEntries.map(e => typeof e === 'function' ? e() : e));
                  const config = this.core.config('desktop.contextmenu');
                  const hasIconview = this.core.make('osjs/settings').get('osjs/desktop', 'iconview.enabled');
              Severity: Minor
              Found in src/desktop.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _maximize has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
              Open

                _maximize(toggle) {
                  if (this._toggleState('maximized', toggle, toggle ? 'maximize' : 'restore')) {
                    const emit = () => this.emit('resized', {
                      width: this.$element ? this.$element.offsetWidth : -1,
                      height: this.$element ? this.$element.offsetHeight : -1
              Severity: Minor
              Found in src/window.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function _launch has 59 lines of code (exceeds 50 allowed). Consider refactoring.
              Open

                _launch(name, metadata, args, options) {
                  const _ = this.core.make('osjs/locale').translate;
                  const canLaunch = createPackageAvailabilityCheck(this.core);
              
                  const dialog = e => {
              Severity: Major
              Found in src/packages.js - About 1 hr to fix

                Function createFetchOptions has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                Open

                const createFetchOptions = (url, options, type) => {
                  const fetchOptions = {
                    credentials: 'same-origin',
                    method: 'get',
                    headers: {},
                Severity: Minor
                Found in src/utils/fetch.js - About 1 hr to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function onContextMenu has 55 lines of code (exceeds 50 allowed). Consider refactoring.
                Open

                  onContextMenu(ev) {
                    const lockSettings = this.core.config('desktop.lock');
                    const extras = [].concat(...this.contextmenuEntries.map(e => typeof e === 'function' ? e() : e));
                    const config = this.core.config('desktop.contextmenu');
                    const hasIconview = this.core.make('osjs/settings').get('osjs/desktop', 'iconview.enabled');
                Severity: Major
                Found in src/desktop.js - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language