Sign upLogin

os-js/osjs-server

View on GitHub
Star

Showing 17 of 17 total issues

Function createRequestFactory has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

const createRequestFactory = findMountpoint => (getter, method, readOnly, respond) => async (req, res) => {
  const call = async (target, rest, options) => {
    const found = await findMountpoint(target);
    const attributes = found.mount.attributes || {};
    const strict = attributes.strictGroups !== false;
Severity: Minor
Found in src/vfs.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 129 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = (core) => {
  const wrapper = (method, cb, ...args) => vfs => (file, options = {}) => {
    const promise = Promise.resolve(getRealPath(core, options.session, vfs.mount, file))
      .then(realPath => fs[method](realPath, ...args));
Severity: Major
Found in src/adapters/vfs/system.js - About 5 hrs to fix

    Function createRequestFactory has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const createRequestFactory = findMountpoint => (getter, method, readOnly, respond) => async (req, res) => {
  const call = async (target, rest, options) => {
    const found = await findMountpoint(target);
    const attributes = found.mount.attributes || {};
    const strict = attributes.strictGroups !== false;
    Severity: Major
    Found in src/vfs.js - About 2 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            Promise.resolve(getRealPath(core, options.session, vfs.mount, root))
        .then(realPath => fs.readdir(realPath).then(files => ({realPath, files})))
        .then(({realPath, files}) => {
          const promises = files.map(f => createFileIter(core, realPath, root.replace(/\/?$/, '/') + f));
          return Promise.all(promises);
      Severity: Major
      Found in src/adapters/vfs/system.js and 1 other location - About 1 hr to fix
      src/adapters/vfs/system.js on lines 223..236

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            Promise.resolve(getRealPath(core, options.session, vfs.mount, file))
        .then(realPath => fs.stat(realPath).then(stat => ({realPath, stat})))
        .then(({realPath, stat}) => {
          if (!stat.isFile()) {
            return false;
      Severity: Major
      Found in src/adapters/vfs/system.js and 1 other location - About 1 hr to fix
      src/adapters/vfs/system.js on lines 209..214

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 72.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function call has 44 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const call = async (target, rest, options) => {
    const found = await findMountpoint(target);
    const attributes = found.mount.attributes || {};
    const strict = attributes.strictGroups !== false;
      Severity: Minor
      Found in src/vfs.js - About 1 hr to fix

        Function exports has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports = (core) => {
  const wrapper = (method, cb, ...args) => vfs => (file, options = {}) => {
    const promise = Promise.resolve(getRealPath(core, options.session, vfs.mount, file))
      .then(realPath => fs[method](realPath, ...args));
        Severity: Minor
        Found in src/adapters/vfs/system.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            try {
      this.adapter = this.options.adapter(core, this.options.config);
    } catch (e) {
      this.core.logger.warn(e);
    }
        Severity: Major
        Found in src/auth.js and 1 other location - About 1 hr to fix
        src/settings.js on lines 72..76

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            try {
      this.adapter = this.options.adapter(core, this.options.config);
    } catch (e) {
      this.core.logger.warn(e);
    }
        Severity: Major
        Found in src/settings.js and 1 other location - About 1 hr to fix
        src/auth.js on lines 92..96

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 65.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function initSocketRoutes has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          initSocketRoutes() {
    const {app} = this.core;

    app.ws('/', (ws, req) => {
      ws.upgradeReq = ws.upgradeReq || req;
        Severity: Minor
        Found in src/providers/core.js - About 1 hr to fix

          Function initService has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            initService() {
    const {app} = this.core;
    const {requireAllGroups} = this.core.configuration.auth;

    const middleware = {
          Severity: Minor
          Found in src/providers/core.js - About 1 hr to fix

            Function exports has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            module.exports = core => {
  const router = express.Router();
  const methods = vfs(core);
  const middleware = createMiddleware(core);
  const {isAuthenticated} = core.make('osjs/express');
            Severity: Minor
            Found in src/vfs.js - About 1 hr to fix

              Function listen has 31 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                async listen() {
    const httpPort = this.config('port');
    const httpHost = this.config('bind');
    const wsPort = this.config('ws.port') || httpPort;
    const pub = this.config('public');
              Severity: Minor
              Found in src/core.js - About 1 hr to fix

                Function onDone has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                const onDone = (req, res) => {
  if (req.files) {
    for (let fieldname in req.files) {
      try {
        const n = req.files[fieldname].path;
                Severity: Minor
                Found in src/vfs.js - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function destroy has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                  async destroy(done = () => {}) {
    if (this.destroyed) {
      return;
    }
                Severity: Minor
                Found in src/core.js - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function createCrossRequestFactory has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                const createCrossRequestFactory = findMountpoint => (getter, method, respond) => async (req, res) => {
  const [from, to, options] = [...getter(req, res), createOptions(req)];

  const srcMount = await findMountpoint(from);
  const destMount = await findMountpoint(to);
                Severity: Minor
                Found in src/vfs.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function createOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                const createOptions = req => {
  const options = req.fields.options;
  const range = req.headers && req.headers.range;
  const session = {...req.session || {}};
  let result = options || {};
                Severity: Minor
                Found in src/vfs.js - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language