Sign upLogin

os-js/osjs-server

View on GitHub
Star
src/vfs.js

Summary

Maintainability
D
1 day
Test Coverage
F
55%

Function createRequestFactory has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

const createRequestFactory = findMountpoint => (getter, method, readOnly, respond) => async (req, res) => {
  const call = async (target, rest, options) => {
    const found = await findMountpoint(target);
    const attributes = found.mount.attributes || {};
    const strict = attributes.strictGroups !== false;
Severity: Minor
Found in src/vfs.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function createRequestFactory has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const createRequestFactory = findMountpoint => (getter, method, readOnly, respond) => async (req, res) => {
  const call = async (target, rest, options) => {
    const found = await findMountpoint(target);
    const attributes = found.mount.attributes || {};
    const strict = attributes.strictGroups !== false;
Severity: Major
Found in src/vfs.js - About 2 hrs to fix

    Function call has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const call = async (target, rest, options) => {
    const found = await findMountpoint(target);
    const attributes = found.mount.attributes || {};
    const strict = attributes.strictGroups !== false;
    Severity: Minor
    Found in src/vfs.js - About 1 hr to fix

      Function exports has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = core => {
  const router = express.Router();
  const methods = vfs(core);
  const middleware = createMiddleware(core);
  const {isAuthenticated} = core.make('osjs/express');
      Severity: Minor
      Found in src/vfs.js - About 1 hr to fix

        Function onDone has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        const onDone = (req, res) => {
  if (req.files) {
    for (let fieldname in req.files) {
      try {
        const n = req.files[fieldname].path;
        Severity: Minor
        Found in src/vfs.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createCrossRequestFactory has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        const createCrossRequestFactory = findMountpoint => (getter, method, respond) => async (req, res) => {
  const [from, to, options] = [...getter(req, res), createOptions(req)];

  const srcMount = await findMountpoint(from);
  const destMount = await findMountpoint(to);
        Severity: Minor
        Found in src/vfs.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function createOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        const createOptions = req => {
  const options = req.fields.options;
  const range = req.headers && req.headers.range;
  const session = {...req.session || {}};
  let result = options || {};
        Severity: Minor
        Found in src/vfs.js - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status