Sign upLogin

osbridge/openconferenceware

View on GitHub
Star
app/controllers/open_conference_ware/application_controller.rb

Summary

Maintainability
D
2 days
Test Coverage

Class ApplicationController has 37 methods (exceeds 20 allowed). Consider refactoring.
Open

  class ApplicationController < ActionController::Base

    helper :all # include all helpers, all the time

    # See ActionController::RequestForgeryProtection for details
Severity: Minor
Found in app/controllers/open_conference_ware/application_controller.rb - About 4 hrs to fix

    File application_controller.rb has 349 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    module OpenConferenceWare
  # Filters added to this controller apply to all controllers in the application.
  # Likewise, all the methods added will be available for all controllers.

  class ApplicationController < ActionController::Base
    Severity: Minor
    Found in app/controllers/open_conference_ware/application_controller.rb - About 4 hrs to fix

      Method get_current_event_and_assignment_status has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          def get_current_event_and_assignment_status
      invalid = false

      # Try finding event using params:
      event_id_key = controller_name == "events" ? :id : :event_id
      Severity: Minor
      Found in app/controllers/open_conference_ware/application_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method normalize_event_path_or_redirect has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          def normalize_event_path_or_redirect
      # When running under a prefix (e.g., "thin --prefix /omg start"), this value will be set to "/omg", else "".
      if request.format.to_sym == :html
        if request.path.match(%r{^#{OpenConferenceWare.mounted_path("/events")}})
          return false
      Severity: Minor
      Found in app/controllers/open_conference_ware/application_controller.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method warn_about_incomplete_event has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          def warn_about_incomplete_event
      if @event
        if event_tracks? && @event.tracks.size == 0
          if admin?
            notify :notice, "This event needs a track, you should #{view_context.link_to 'create one', new_event_track_path(@event)}.".html_safe
      Severity: Minor
      Found in app/controllers/open_conference_ware/application_controller.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method get_current_event_and_assignment_status has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def get_current_event_and_assignment_status
      invalid = false

      # Try finding event using params:
      event_id_key = controller_name == "events" ? :id : :event_id
      Severity: Minor
      Found in app/controllers/open_conference_ware/application_controller.rb - About 1 hr to fix

        Method can_edit? has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def can_edit?(record)
      raise ArgumentError, "No record specified" unless record

      if logged_in?
        if current_user.admin?
        Severity: Minor
        Found in app/controllers/open_conference_ware/application_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method assert_user has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            def assert_user
      case self
      when UsersController
        user_id = params[:id]
      when UserFavoritesController
        Severity: Minor
        Found in app/controllers/open_conference_ware/application_controller.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method assert_proposal_status_published has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def assert_proposal_status_published
      display = false
      if @event.proposal_status_published?
        display = true
      else
        Severity: Minor
        Found in app/controllers/open_conference_ware/application_controller.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method assert_schedule_published has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def assert_schedule_published
      display = admin? || schedule_visible?
      flash[:notice] = "The schedule has not yet been published, only admins can see this page." if admin? && !schedule_visible?

      unless display
        Severity: Minor
        Found in app/controllers/open_conference_ware/application_controller.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                return false
        Severity: Major
        Found in app/controllers/open_conference_ware/application_controller.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return [nil, :empty]
          Severity: Major
          Found in app/controllers/open_conference_ware/application_controller.rb - About 30 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  @proposals_for_user_hash  = Defer { @users_and_proposals.inject({}){|s,v| (s[v["user_id"].to_i] ||= Set.new) << @proposals_hash[v["proposal_id"].to_i]; s} }
            Severity: Minor
            Found in app/controllers/open_conference_ware/application_controller.rb and 2 other locations - About 15 mins to fix
            app/controllers/open_conference_ware/application_controller.rb on lines 463..463
            app/controllers/open_conference_ware/application_controller.rb on lines 464..464

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 26.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  @users_for_proposal_hash  = Defer { @users_and_proposals.inject({}){|s,v| (s[v["proposal_id"].to_i] ||= Set.new) << @users_hash[v["user_id"].to_i]; s} }
            Severity: Minor
            Found in app/controllers/open_conference_ware/application_controller.rb and 2 other locations - About 15 mins to fix
            app/controllers/open_conference_ware/application_controller.rb on lines 464..464
            app/controllers/open_conference_ware/application_controller.rb on lines 465..465

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 26.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                  @sessions_for_user_hash   = Defer { @users_and_sessions.inject({}){|s,v| (s[v["user_id"].to_i] ||= Set.new) << @sessions_hash[v["proposal_id"].to_i]; s} }
            Severity: Minor
            Found in app/controllers/open_conference_ware/application_controller.rb and 2 other locations - About 15 mins to fix
            app/controllers/open_conference_ware/application_controller.rb on lines 463..463
            app/controllers/open_conference_ware/application_controller.rb on lines 465..465

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 26.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status